search

clowd / Clowd.Squirrel

Quick and easy installer and automatic updates for cross-platform dotnet applications
426 stars 39 forks source link

Shortcuts will be created for net6.0 included executables like `createdump.exe` #53

Closed peppy closed 2 years ago

peppy commented 2 years ago

I've started looking into this project as a potential drop-in replacement for squirrel, which we currently have forked to apply some bug fixes. One of these is to avoid the installer creating shortcuts for every executable that is in the package directory.

As of net5.0 or net6.0 we noticed that createdump.exe is included as standard with dotnet publish output. We could probably trim this, but interested in your thoughts on whether there is a better way to explicitly define which shortcuts to make, rather than blanket creating them for all executables (seems like a very rare scenario that more than one would exist).

The fix we have applied is a bit of a hotfix one (https://github.com/ppy/Squirrel.Windows/commit/db2bc0bed69916f3f65d74777131118a3174712f), but does the job for our needs. If you can confirm that createdump is a common thing (seems to still be), it may be worth applying the same fix as an interim best-effort. I'm happy to PR that if it helps.

peppy commented 2 years ago

Apologies, jumped the gun on this one (was looking at the "legacy" flow when SquirrelAwareVersion is not present). Looks like the new way you have things working is pretty solid.