search

clowder-framework / CONSORT-frontend

custom react frontend working with consort clowder instance
0 stars 0 forks source link

22 move html display to results page #23

Closed minump closed 1 year ago

minump commented 1 year ago

This PR is built on top of https://github.com/clowder-framework/CONSORT-frontend/pull/21 Uses redux.

Things implemented in this PR :

  1. Creating dataset and adding file is separated into two different actions.
  2. Some UI changes - text in Into component & Spirit and Consort logos beside radio buttons.
  3. Html file preview is moved to /preview page. Used 'useNavigate' package from react-router-dom. A "Continue" button is implemented. On page load, the button is disabled. When user uploads a file and extraction is successful, the button is enabled. Onclick it redirects to '/preview' page where the html iframe is displayed.

Need to update changelog. Changelog will be updated once PR review is done.

minump commented 1 year ago

In the mockups, does the page automatically go to the results or is there a continue button?

Could we rename continue to "View Results" or something similar?

There is a "Continue" button in figma design workspace. Button text updated to "View Results". Updated changelog.

Code updated according to feedback. Ready for review. @lmarini