Added GLTF loading capabilities to viewer_three.js previewer as well as a loading screen

clowder-framework / clowder

A data management system that allows users to share, annotate, organize and analyze large collections of datasets. It provides support for extensible metadata annotation using JSON-LD and a distribute analytics event bus for automatic curation of uploaded data.

https://clowderframework.org/

University of Illinois/NCSA Open Source License

37 stars 17 forks source link

Added GLTF loading capabilities to viewer_three.js previewer as well as a loading screen #304

Closed cconsta1 closed 2 years ago

cconsta1 commented 2 years ago

Description

Added the ability to load GLTF files
Fixed positioning issues with the 3D model
Added a loading screen

Review Time Estimate

[ ] Immediately
[ ] Within one week
[x ] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the CHANGELOG.md.
[x] I have signed the CLA
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

robkooper commented 2 years ago

looks like you deleted .gitignore as well as the docker-compose files, can you undo those changes please.

cconsta1 commented 2 years ago

looks like you deleted .gitignore as well as the docker-compose files, can you undo those changes please.

Hi @robkooper! I think I reverted the files following @lmarini instructions. Can you check, please? If not I'll delete this pull request and start over. Thanks for checking!

CLAassistant commented 2 years ago

All committers have signed the CLA.

lmarini commented 2 years ago

Hi @cconsta1 will you be making a new PR with this work?

cconsta1 commented 2 years ago

Hi Luigi! Yes. It’ll combine some improvements of the GLTF previewer and the new IFC previewer :)

Sent from my iPhone

On Mar 24, 2022, at 3:53 PM, Luigi Marini @.***> wrote:

Hi @cconsta1 will you be making a new PR with this work?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.