clowder-framework / clowder

A data management system that allows users to share, annotate, organize and analyze large collections of datasets. It provides support for extensible metadata annotation using JSON-LD and a distribute analytics event bus for automatic curation of uploaded data.
https://clowderframework.org/
University of Illinois/NCSA Open Source License
35 stars 17 forks source link

Setting a dataset to public without a space results in access controls showing #328

Open lmarini opened 2 years ago

lmarini commented 2 years ago

This is with permissions = private, enablePublic = true, verifySpaces = true.

When creating a new dataset from the GUI there is no Access controls. Access controls are there when creating a dataset through API and setting "access":"PUBLIC". Access controls should only be available when a dataset is in a space (if you put your dataset in a space you will see them show up).

Check view tample to see fix the logic showing the controls.

To Reproduce Steps to reproduce the behavior:

  1. Create a dataset using POST api/datasets/createempty and set "access":"PUBLIC" and "space":[].
  2. Go to dataset in GUI and notice that Access controls are showing without one being selected.

Expected behavior Access controls should not be showing unless a dataset is shared in a space.

Screenshots

Screen Shot 2022-02-24 at 9 41 29 AM

Desktop (please complete the following information):