Added an IFC previewer and a GLTF previewer

clowder-framework / clowder

A data management system that allows users to share, annotate, organize and analyze large collections of datasets. It provides support for extensible metadata annotation using JSON-LD and a distribute analytics event bus for automatic curation of uploaded data.

https://clowderframework.org/

University of Illinois/NCSA Open Source License

35 stars 17 forks source link

Added an IFC previewer and a GLTF previewer #340

Closed cconsta1 closed 2 years ago

cconsta1 commented 2 years ago

Description

I implemented an IFC previewer and added GLTF loading capabilities to the three_js previewer

Review Time Estimate

[ ] Immediately
[ ] Within one week
[X] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[X] I have updated the CHANGELOG.md.
[X] I have signed the CLA
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: cconsta1
:white_check_mark: lmarini
:x: Chrysovalantis Constantinou

Chrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

cconsta1 commented 2 years ago

I found an IFC file for testing here and GLTF files can be found here.

lmarini commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ cconsta1❌ Chrysovalantis Constantinou Chrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

@cconsta1 it looks like the commit from 4 days ago was done using a different username. Can you approve the CLA using that username as well? Thanks!

cconsta1 commented 2 years ago

Hi @lmarini,

I got a new machine and when I made the first commit, my local git on my machine was not linked to my email account yet. I did that after I made my first commit, that's why the only thing that appears in the first commit is my name (Chrysovalantis Constantinou), whereas with the second and third commits my regular username cconsta1 appears. Is there a way around this? Or shall I close this pr and open a new one?

lmarini commented 2 years ago

Hi @lmarini,

I got a new machine and when I made the first commit, my local git on my machine was not linked to my email account yet. I did that after I made my first commit, that's why the only thing that appears in the first commit is my name (Chrysovalantis Constantinou), whereas with the second and third commits my regular username cconsta1 appears. Is there a way around this? Or shall I close this pr and open a new one?

That's fine. Thanks for the clarification. Since there isn't another email/account specified, I think we good.

cconsta1 commented 2 years ago

@lmarini, that's cool then! I also changed the mimetypes by adding model/ifc, model/IFC. I hope things work and thanks!

cconsta1 commented 2 years ago

Awesome! Thanks @lmarini!