clowder-framework / clowder

A data management system that allows users to share, annotate, organize and analyze large collections of datasets. It provides support for extensible metadata annotation using JSON-LD and a distribute analytics event bus for automatic curation of uploaded data.
https://clowderframework.org/
University of Illinois/NCSA Open Source License
34 stars 17 forks source link

Custom metadata tags NOT submitting #350

Open taywll252 opened 2 years ago

taywll252 commented 2 years ago

Describe the bug User is unable to use their custom metadata tag fields. Custom fields are able to be created, but they do not submit/save entries when submitted to a file. Only tested in the UI, unknown if the API is affected.

To Reproduce Steps to reproduce the behavior:

  1. Go to a Clowder Space
  2. Create a new metadata tag using the "Manage Metadata Terms & Definitions" link (just a name and description with default type "String" is sufficient)
  3. Navigate to a file within a dataset within the Space
  4. Try to add the newly created metadata tag to the file (enter test information and click submit button)
  5. See error where tag is not added

The error also presents when:

  1. Complete steps 1-3 above
  2. Click the "Advanced" tab button on the "Add Metadata" tab
  3. Try to input the newly created metadata tag along with other default tags (enter test information and click submit button)
  4. See error where default tags are added, but not the new custom tag

Expected behavior User is able to create custom metadata tag fields to then submit metadata with a file.

Screenshots Attempt to submit metadata (custom and default tag fields) metadata_error

Only the default tag field was submitted successfully (custom tag not submitted) metadata_error2

Desktop (please complete the following information):

taywll252 commented 2 years ago

Update on this bug. With more testing, it seems the issue is the "." in the metadata tag name, where "1. Hero ID" doesn't work, but "1 Hero ID" does work.

robkooper commented 1 year ago

@lmarini , @ddey2 and @max-zilla can we touch base about this on Friday? Would it make sense to just remove "bad" characters (like .) from the text?