Added Google's model viewer within viewer_three.js

cconsta1 commented 2 years ago

Description

Review Time Estimate

[ ] Immediately
[ ] Within one week
[ X] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the CHANGELOG.md.
[ X] I have signed the CLA
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: lmarini
:white_check_mark: cconsta1
:x: Chrysovalantis Constantinou

Chrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

cconsta1 commented 2 years ago

Hi! To test the changes please use the attached file containing 3D models :) models.zip

cconsta1 commented 1 year ago

Hi Luigi,

Maybe this has something to do with the fact that I now used Google’s model viewer to load the GLB files instead of the three.js library (which I used before). But no it’s not intentional. I can check tomorrow. However, I did notice the viewport getting huge, which happens when I load 3D models with the developer tools open. I don’t know why that happens to be honest. To reproduce this, please load a file with the tools open and once it loads close the dev tools.

Best regards, Valentino

Sent from my iPhone

On Aug 29, 2022, at 11:48 PM, Luigi Marini @.***> wrote:

@lmarini requested changes on this pull request.

I noticed that when viewing .glb files the viewerport is much smaller than when viewing .fbx. Is that intentional?

Testing on firefox and chrome on mac.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

lmarini commented 1 year ago

Hi Luigi, Maybe this has something to do with the fact that I now used Google’s model viewer to load the GLB files instead of the three.js library (which I used before). But no it’s not intentional. I can check tomorrow. However, I did notice the viewport getting huge, which happens when I load 3D models with the developer tools open. I don’t know why that happens to be honest. To reproduce this, please load a file with the tools open and once it loads close the dev tools. Best regards, Valentino … Sent from my iPhone On Aug 29, 2022, at 11:48 PM, Luigi Marini @.***> wrote: @lmarini requested changes on this pull request. I noticed that when viewing .glb files the viewerport is much smaller than when viewing .fbx. Is that intentional? Testing on firefox and chrome on mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

@cconsta1 I tried with developer tools open on both firefox and chrome but the same thing happens.

cconsta1 commented 1 year ago

Hi Luigi,

I think I know what the problem might be. The GLB file loads using the element . On my first try, the viewport was as small as yours in the picture but I remedied that by adding a CSS entry:

model-viewer { width: 640px; height: 480px; }

The CSS file (style.css) loads inside the viewer_three.js file. Somehow, it's not working on your side. I can check tomorrow. I'm attaching what I'm seeing on my side.

Regards, Valentino

On Tue, Aug 30, 2022 at 1:00 AM Luigi Marini @.***> wrote:

Hi Luigi, Maybe this has something to do with the fact that I now used Google’s model viewer to load the GLB files instead of the three.js library (which I used before). But no it’s not intentional. I can check tomorrow. However, I did notice the viewport getting huge, which happens when I load 3D models with the developer tools open. I don’t know why that happens to be honest. To reproduce this, please load a file with the tools open and once it loads close the dev tools. Best regards, Valentino … <#m-7621028661472024347> Sent from my iPhone On Aug 29, 2022, at 11:48 PM, Luigi Marini @.***> wrote: @lmarini https://github.com/lmarini requested changes on this pull request. I noticed that when viewing .glb files the viewerport is much smaller than when viewing .fbx. Is that intentional? Testing on firefox and chrome on mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

@cconsta1 https://github.com/cconsta1 I tried with developer tools open on both firefox and chrome but the same thing happens.

— Reply to this email directly, view it on GitHub https://github.com/clowder-framework/clowder/pull/372#issuecomment-1230907876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA . You are receiving this because you were mentioned.Message ID: @.***>

lmarini commented 1 year ago

Thank you, Valentino. So you have the same problem, but adding the model-viewer style at run time fixes it? Do you always have to add it after you refresh the page?

Thank you, Luigi

From: Chrysovalantis Constantinou @.> Date: Monday, August 29, 2022 at 5:17 PM To: clowder-framework/clowder @.> Cc: Marini, Luigi @.>, Mention @.> Subject: Re: [clowder-framework/clowder] Added Google's model viewer within viewer_three.js (PR #372) Hi Luigi,

I think I know what the problem might be. The GLB file loads using the element . On my first try, the viewport was as small as yours in the picture but I remedied that by adding a CSS entry:

model-viewer { width: 640px; height: 480px; }

The CSS file (style.css) loads inside the viewer_three.js file. Somehow, it's not working on your side. I can check tomorrow. I'm attaching what I'm seeing on my side.

Regards, Valentino

On Tue, Aug 30, 2022 at 1:00 AM Luigi Marini @.***> wrote:

Hi Luigi, Maybe this has something to do with the fact that I now used Google’s model viewer to load the GLB files instead of the three.js library (which I used before). But no it’s not intentional. I can check tomorrow. However, I did notice the viewport getting huge, which happens when I load 3D models with the developer tools open. I don’t know why that happens to be honest. To reproduce this, please load a file with the tools open and once it loads close the dev tools. Best regards, Valentino … <#m-7621028661472024347> Sent from my iPhone On Aug 29, 2022, at 11:48 PM, Luigi Marini @.**> wrote: @lmarini https://github.com/lmarini<https://urldefense.com/v3/__https:/github.com/lmarini3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDKxwJz6Uw$> requested changes on this pull request. I noticed that when viewing .glb files the viewerport is much smaller than when viewing .fbx. Is that intentional? Testing on firefox and chrome on mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

@cconsta1 https://github.com/cconsta1 https://urldefense.com/v3/__https:/github.com/cconsta1*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDKy_kXjYA$ I tried with developer tools open on both firefox and chrome but the same thing happens.

— Reply to this email directly, view it on GitHub https://github.com/clowder-framework/clowder/pull/372#issuecomment-1230907876 https://urldefense.com/v3/__https:/github.com/clowder-framework/clowder/pull/372*issuecomment-1230907876*3E__;IyU!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDIDdxqp5w$, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDI1UqVq3g$ . You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/clowder-framework/clowder/pull/372*issuecomment-1230926749__;Iw!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDJUPfQwcQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AAESNLJNFJK6UEX6SBM6HD3V3UZI5ANCNFSM56ODJLIA__;!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDIMAOdu0w$. You are receiving this because you were mentioned.Message ID: @.***>

cconsta1 commented 1 year ago

Hi! I think I never answered this! What do you mean by loading the CSS style at run time?

clowder-framework / clowder