search

clowder-framework / clowder

A data management system that allows users to share, annotate, organize and analyze large collections of datasets. It provides support for extensible metadata annotation using JSON-LD and a distribute analytics event bus for automatic curation of uploaded data.
https://clowderframework.org/
University of Illinois/NCSA Open Source License
34 stars 17 forks source link

Extractors appear on the "Submit file for extraction" page after being disabled. #387

Closed MWesner3344 closed 1 year ago

MWesner3344 commented 1 year ago

Describe the bug Extractors still show up on the "Submit file for extraction" page after being disabled. The "Enabled" box is unchecked but the extractors appear as available to submit a file for extraction.

To Reproduce Steps to reproduce the behavior:

  1. Disable an extractor on the Extractors page.
  2. Go to a file and click on the "Submit file for extraction" button.
  3. The disabled extractors are still on this page and have the "Submit" button activated.

Expected behavior The disabled extractor should be removed from the "Submit file for extraction" page or the "Submit" button should be grayed out.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

lmarini commented 1 year ago

@ddey2 can you try to reproduce? Thank you.

ddey2 commented 1 year ago

I am looking into this. I ll keep you posted.

ddey2 commented 1 year ago

I have reproduced the issue. It looks like disabling the extractor doesn't remove the extractor from the list of available extractors. I will address this soon.

robkooper commented 1 year ago

Hi @MWesner3344 the ability to enable/disable extractors is not for making them visible and runnable, but have them automatically run when new data is uploaded. So I believe right now it is working as intended.

We are working however on the code to make an extractor private, such that only a specific user can use it, see #300. We hope to soon be able to merge this, enabling the ability to have extractors that are hidden from others.

I will mark this issue as closed for now, but feel free to reopen if I mis understood the issue.