search

clowder-framework / clowder

A data management system that allows users to share, annotate, organize and analyze large collections of datasets. It provides support for extensible metadata annotation using JSON-LD and a distribute analytics event bus for automatic curation of uploaded data.
https://clowderframework.org/
University of Illinois/NCSA Open Source License
33 stars 17 forks source link

Fixed hearthbeat bug #429

Closed lmarini closed 8 months ago

lmarini commented 8 months ago

where if the owner was not set in extractors_info.json clowder would throw and error and the extractor would not get registered.

lmarini commented 8 months ago

@max-zilla can you test a private extractor that includes an owner in extractor_info.json. Thank you.

minump commented 8 months ago

I was able to test this as well. Ran ghcr.io/clowder-framework/clowder:PR-429, deleted a private extractor from UI (http://localhost:8000/extractors/pdfminer-extractor) . Saw that the extractor came back on (name popped up in the list of extractors) after heartbeat time.

Tested. works fine. approving.

lmarini commented 8 months ago

I was able to test this as well. Ran ghcr.io/clowder-framework/clowder:PR-429, deleted a private extractor from UI (http://localhost:8000/extractors/pdfminer-extractor) . Saw that the extractor came back on (name popped up in the list of extractors) after heartbeat time.

Tested. works fine. approving.

Thanks! Next time feel free to add yourself to list of reviewers.