clowdfish / 1clicktrips

[Pro-113] The business traveler platform offering end to end trip management.
http://www.1clicktrips.com
1 stars 1 forks source link

Add Google maps to result screen #297

Closed swapzone closed 8 years ago

swapzone commented 8 years ago

[Req-95] See design draft for details.

Also show route when "show on map" is clicked.

1clicktrips_result

davidtran commented 8 years ago

Streetview api doesn't have image for certain locations. I also suggest that we should provide destionation name and address in search trip api, right now it just return "Destination".

davidtran commented 8 years ago

I have added a draft marker. Tonight, I will continue on this task.

swapzone commented 8 years ago

I will add an issue for the address topic in the back end.

swapzone commented 8 years ago

It's pretty cool, that you can interact with the Google Maps in the result screen. You can even switch to street view and use it within our app :)

davidtran commented 8 years ago

Found an issue with path data from search engine. It is not always correct. In the picture is the path data of a trip from Vietnam to Thailand. screen shot 2015-10-26 at 9 31 01 am

davidtran commented 8 years ago

it's correct in this case: screen shot 2015-10-26 at 9 29 04 am

swapzone commented 8 years ago

Is the path wrong or are the coordinates of the locations wrong?

swapzone commented 8 years ago

Did you recognise, that there is no path information for flight data? So if there is a flight, you need to draw the direct line between start and end location.

davidtran commented 8 years ago

for flight trip, I use start and end location to draw the path. You can see in the images in comment, the first itinerary is not correct, but the second one is correct.

swapzone commented 8 years ago

We should try to reduce the height of the map to the original height, once the user scrolls back down.

swapzone commented 8 years ago

Done.