search

clowdr-app / clowdr

Midspace (formerly Clowdr) is a completely open-source virtual conference platform. Host complex events with hundreds of authors and presenters. Midspace includes automated livestreams, video chat, text chat, randomised networking and much more.
https://www.midspace.app/
GNU Affero General Public License v3.0
59 stars 20 forks source link

Broken subtitles editor content with segments starting at "00:05:48,1000" #257

Open fzieris opened 3 years ago

fzieris commented 3 years ago

Describe the bug While editing the auto-generated subtitles, segments close to full seconds might produce broken subtitles.

To Reproduce I have not found a guaranteed way to reproduce it, but here is what I did:

  1. Upload a video
  2. Wait for the subtitles to be automatically generated
  3. Edit some of them
  4. Save the changes
  5. Reload the website (enter the same URL again)
  6. Possibly see broken entries (see screenshot below).

Expected behavior The editor should display time codes and subtitles neatly separated in two columns, and not mingle time code information with the subtitles proper.

Screenshots screenshot

The segments 142 and 143 and not displayed as separate lines, but as part of segment 141. This is likely because of the faulty number format of "00:05:48,1000" which is probably one millisecond after "00:05:48,999" and should this be "00:05:49,000". I guess this makes some regex trip which expected exactly three digits after a comma to separate subtitle metadata from the subtitles proper.

Desktop (please complete the following information):

rossng commented 3 years ago

Thanks for reporting this - we will look into it.