Documentation fix for hasura/config.yaml

clowdr-app / clowdr

Midspace (formerly Clowdr) is a completely open-source virtual conference platform. Host complex events with hundreds of authors and presenters. Midspace includes automated livestreams, video chat, text chat, randomised networking and much more.

https://www.midspace.app/

GNU Affero General Public License v3.0

60 stars 20 forks source link

Documentation fix for hasura/config.yaml #389

Closed nguerette closed 2 years ago

nguerette commented 2 years ago

What's [new / improved / fixed]

Remove hasura config example file and document adding admin secret to versioned config file

EdNutting commented 2 years ago

I don't believe adding the admin secret to the Hasura config.yaml file is ever necessary. It is set via the env var which is passed through to Hasura via the docker compose file.

Can someone please verify that this is correct? My test setup works but I've not had enough time to be fully confident that I've tested it properly.

nguerette commented 2 years ago

I don't believe adding the admin secret to the Hasura config.yaml file is ever necessary. It is set via the env var which is passed through to Hasura via the docker compose file.

Can someone please verify that this is correct? My test setup works but I've not had enough time to be fully confident that I've tested it properly.

Looks like this is true, it works for me without admin secret in config.yaml, and that also resolves the concern about accidentally committing it that led me to git-ignoring config.yaml. Have fixed up the README now.