Closed ssnickolay closed 6 years ago
let's rename ByBlockFilter and ByKeyFilter to just BlockFilter and KeyFilter respectively.
I agree :+1:
And for AllowFilter and DenyFilter, maybe, it would be better to use something like PassFilter and NullFilter.
I think NullFilter
not very good class name, because it's sounds like EmptyFilter
or WithoutFilter
(
I think NullFilter not very good class name, because it's sounds like EmptyFilter or WithoutFilter(
What about using Proxy
instead of Filter
? Then NullProxy
makes sense
What about using Proxy instead of Filter? Then NullProxy makes sense
Hm, I like it :+1:
@palkan It looks like we're done. Can you look again, please?
@palkan done :+1: Feel free to merge to master)
Closes #15