clowne-rb / clowne

A flexible gem for cloning models
https://clowne.evilmartians.io
MIT License
317 stars 18 forks source link

Add control over associations params #17

Closed ssnickolay closed 6 years ago

ssnickolay commented 6 years ago

Closes #15

ssnickolay commented 6 years ago

let's rename ByBlockFilter and ByKeyFilter to just BlockFilter and KeyFilter respectively.

I agree :+1:

And for AllowFilter and DenyFilter, maybe, it would be better to use something like PassFilter and NullFilter.

I think NullFilter not very good class name, because it's sounds like EmptyFilter or WithoutFilter(

palkan commented 6 years ago

I think NullFilter not very good class name, because it's sounds like EmptyFilter or WithoutFilter(

What about using Proxy instead of Filter? Then NullProxy makes sense

ssnickolay commented 6 years ago

What about using Proxy instead of Filter? Then NullProxy makes sense

Hm, I like it :+1:

ssnickolay commented 6 years ago

@palkan It looks like we're done. Can you look again, please?

ssnickolay commented 6 years ago

@palkan done :+1: Feel free to merge to master)