search

clowne-rb / clowne

A flexible gem for cloning models
https://clowne.evilmartians.io
MIT License
317 stars 18 forks source link

Ruby 3.0 compatibility #57

Closed pomartel closed 3 years ago

pomartel commented 3 years ago

It looks like Clowne is not compatible with Ruby 3.0. I get a lot of errors like these when running the tests suite:

ArgumentError: wrong number of arguments (given 2, expected 1)

This appears to be related to this breaking change in Ruby 3.0.

ssnickolay commented 3 years ago

Hi @pomartel! Ruby 3.0 was released not so long ago, and we didn't have time to support it. I think I'll look at this problem current or next week. BTW we are open to PRs If you want to help with Ruby 3.0 compatibility ;)

pomartel commented 3 years ago

It was my original intention to see if I could submit a PR but this is all a bit too much black belt ruby for me! ;)

Anyways, I was just playing around with Ruby 3.0 and I'm in no rush to upgrade. Thanks for your support!

aserafin commented 3 years ago

@ssnickolay would you consider pushing new release with ruby3 support to rubygems? we're currently forced to refer to master

ssnickolay commented 3 years ago

@aserafin sorry for the delay, I've been a bit busy last few month; I'm going to release it this weekend

ssnickolay commented 3 years ago

The gem has been released: https://rubygems.org/gems/clowne/versions/1.3.0 🎉 @pomartel thanks again for your work!