search

clp-research / clembench

A Framework for the Systematic Evaluation of Chat-Optimized Language Models as Conversational Agents and an Extensible Benchmark
MIT License
22 stars 31 forks source link

script pipeline_huggingfaces.sh overwrite existing key.json #10

Closed davidschlangen closed 10 months ago

davidschlangen commented 11 months ago

As the title says. Script should check whether file exists and only if it doesn't copy the template over. As it is, it will overwrite any existing file, potentially destroying information.

phisad commented 11 months ago

I think it would be save to assume that the user has already prepared the key.json and simply remove that line of code.

Gnurro commented 11 months ago

https://github.com/clp-research/clembench/pull/13

Gnurro commented 10 months ago

The current huggingface pipeline script does nothing with key.json anymore, and the corresponding backend does not use key.json. The HF Llama2 script does check for key.json and notifies the user if it is missing, as the backend needs a viable HF access token to download the weights: https://github.com/clp-research/clembench/blob/f4c457ed5557d8a22b16c046e84024625bd070a4/pipeline_llama2_hf.sh#L5-L11