Change fave icon color when favorited

[anonymous-lemming]

Sometimes when browsing I noticed that my eyes naturally drift to the favorite count icon on a post and see it white even if its favorited. It seems like it would be helpful for myself and maybe others to also tint that favorite icon pink if the post is favorited.

[clragon]

Hi @anonymous-lemming,

Thank you for your PR. The current behaviour is intentional because there are some design conflicts:

• the small icons for the Vote buttons allow the user to vote and change their colors accordingly
• the small favorite icon does not have any interaction but also does not change
• the floating action button (FAB) allows the user to favorite a post and has an animation

unfortunately it is now difficult to bring all these things together on a consistent level.

If the small vote icons allow for voting, should the small fav icon also allow favoriting?

if it allows favoriting, it should animte. however, we dont want to remove the FAB.

if we have both the FAB and the small button to favorite, animating both when either is clicked is very distracting and generally seems strange. additionally, having two buttons for the same thing right next to each other seems somewhat redundant.

All of these considerations have lead to me generally staying at the current state. if you have thoughts regarding this, I would love to hear it.

Best regards.

[clragon]

I have decided that even though this change might be somewhat confusing design wise, just like the current UX, the coloring is a nice addition so we will introduce it anyways.

Thank you for your contribution.