search

clragon / e1547

A sophisticated e621 browser
https://e1547.clynamic.net/
GNU General Public License v3.0
210 stars 16 forks source link

fixed ios build and crash at startup #17

Closed asm-enthusiast closed 3 years ago

asm-enthusiast commented 3 years ago

I fixed the iOs build and a startup crash.

For the build, apparently apple changed what is acceptable for PRODUCT_BUNDLE_IDENTIFIER and in net.e1547 "net." is invalid, so it got changed to clragon.e1547. For the crash, apparently these

<key>NSAppTransportSecurity</key>
<key>NSAllowsArbitraryLoads</key>

are not valid Info.plist keys and would cause a crash at app startup.

I also applied recommendation from XCode 12 which set lower API level to iOs12.

it has been tested on simulator and iPadPro 3rd gen.

clragon commented 3 years ago

looks very good, thank you for your work.

so, net.e1547 is not a valid identifier? very odd.

I will merge this as soon as the splash screen has been resolved.