search

clrfund / monorepo

clr.fund dapp
https://clr.fund/
GNU General Public License v3.0
189 stars 91 forks source link

Add support for more wallets #349

Closed samajammin closed 3 years ago

samajammin commented 3 years ago

Currently (from my understanding) only EIP-1193 providers are supported (https://github.com/clrfund/monorepo/pull/99).

It'd be useful to add a tool like Wallet Connect (e.g. using web3modal) to support mobile & other wallets.

samajammin commented 3 years ago

Note from @auryn-macmillan:

we should integrate web3modal or onboardjs (ideally the Gnosis Safe wrapper for them, so that it is automatically a Gnosis Safe app)

Perhaps you could expand on what adding the Gnosis Safe wrapper would entail? Thanks 😄

xuhcc commented 3 years ago

clrfund only supports wallets that comply with standards. This is intentional

auryn-macmillan commented 3 years ago

Which standards are acceptable to you, @xuhcc ?

xuhcc commented 3 years ago

EIPs

auryn-macmillan commented 3 years ago

I mean which EIP washer standards?

Are there others or just EIP-1193?

auryn-macmillan commented 3 years ago

For instance, EIP-1328 for wallet connect.

This is intentional

What is the intention, @xuhcc?

It seems while it may be idiologically preferable, in practice it may just hurt the user experience for many users, and could ultimately result in less contributions.

xuhcc commented 3 years ago

I'm not aware of any other provider/wallet standards besides EIP-1193.

Actually Wallet Connect does seem to comply with EIP-1193, so its support probably can be added easily.

What is the intention

Non-standard wallets are bad for ecosystem.

ryancreatescopy commented 3 years ago

If WalletConnect could be added that would be ideal as it makes mobile contributions possible! This is something we'll want to add for the eth2 clr – happy to chat through why this might not be possible.

xuhcc commented 3 years ago

If WalletConnect could be added that would be ideal as it makes mobile contributions possible!

I think so, the integration looks straightforward: https://docs.walletconnect.org/quick-start/dapps/web3-provider.

But mobile contributions should be possible already. Have you tried Metamask Mobile or Status?

ryancreatescopy commented 3 years ago

Ah yes but that involves using a web3 browser right? WalletConnect would let users contribute via Brave, Chrome or Safari on mobile, I believe...

On 4 May 2021, at 23:34, Kirill Goncharov @.***> wrote:  If WalletConnect could be added that would be ideal as it makes mobile contributions possible!

I think so, the integration looks straightforward: https://docs.walletconnect.org/quick-start/dapps/web3-provider.

But mobile contributions should be possible already. Have you tried Metamask Mobile or Status?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.