clrfund / monorepo

clr.fund dapp
https://clr.fund/
GNU General Public License v3.0
189 stars 91 forks source link

refactor: get funding round factory information from the subgraph instead of from contract #679

Open yuetloo opened 1 year ago

yuetloo commented 1 year ago

Currently, the code makes 5 contract calls to get all the information instead of just 1 subgraph call to get all information.

cold-briu commented 8 months ago

Hi there! I'm having a similar issue, but I've couldn't find the issue. Can you share how you found that its get funding round factory information hopefully we can fix it togheter

yuetloo commented 8 months ago

@cold-briu , this issue was to track refactoring of this function: https://github.com/clrfund/monorepo/blob/develop/vue-app/src/api/round.ts#L131

But, a lot have changed in the MACI v1 integration branch, so, this issue will be addressed as part of that branch.