Help translating requested

[adipose]

The MPC-HC interface is about 98% translated. Although the application isn't receiving too many new features, when it does it introduces new strings that need translating. If you can help please sign up to translate here:

https://www.transifex.com/mpchc/mpchc/

Click here:

Here is a help page on joining and helping out with the translations:

https://docs.transifex.com/getting-started-1/translators

[xknat]

Send in request to join for translating dutch

[adipose]

Thanks, I approved it.

[NightSharp]

@adipose I've send a request to join for Chinese (China)

[adipose]

@NightSharp you should have been approved now.

[NightSharp]

Thanks a lot

At 2020-03-28 09:21:15, "adipose" notifications@github.com wrote:

@NightSharp you should have been approved now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[ThePirate42]

In some of the english source strings this character can be found: & Sometimes it is mid word. What does it mean?

[clsid2]

That is used for menu shortcuts. So if a menu contains an entry "&Play" you can activate that entry by pressing P while the menu is open.

When translating you can put the & in front of the same letter if the translated string has the same letter. If it doesn't have the same letter, then just remove the &.

[AlexStank]

@adipose I've send a request to join for Russian

[adipose]

@AlexStank , you should have been accepted now.

[moonlightz]

I sent a request to help translating to portuguese of portugal.

[adipose]

I approved it. There is already pt_BR, so maybe you can start with that and update as needed.

[moonlightz]

Thankx. Portuguese of Brasil isn't my language of choice. When I'm using programs (like MPC-HC) or when using webpages like wikipedia, I switch to English if there isn't Portuguese of Portugal. Portuguese of Brasil is just a mix of Portuguese and latin-Spanish and then they tried to mimic'ed the english phrases form. Here in Portugal, we are now facing another silly language rectification which I think it is ridiculous and they are removing letters from the word we don't pronounce or they are lowercasing the initials of the months of the year or of the weekdays or the year seasons. I know most part of MPC-HC and translation should be mid-easy.

[ThePirate42]

The latest release didn't include new transations, is this normal?

[adipose]

Until I sync and merge, they don't get included. I haven't merged them in a few weeks.

[lychichem]

That is used for menu shortcuts. So if a menu contains an entry "&Play" you can activate that entry by pressing P while the menu is open.

When translating you can put the & in front of the same letter if the translated string has the same letter. If it doesn't have the same letter, then just remove the &.

I'm afraid that removing & will cause translated versions of MPC-HC lost the menu shortcut function. The best way is to use a (&) at the end of translated string. For example, &Play will be 播放(&P) after translated to Simplified Chinese.

[moonlightz]

lychichem hit a problem when Chinese and other languages don't use the normal 26 alphabet letters. Putting the shortcut letter between ( and ) with & is a good move. I must say the key shortcuts for menu are hidden since ... XP(?)... maybe Vista and the user needs to have the option enabled to see them or when in a dialog an ALT will make them visible. If the key shortcut can't be used, people which are translating strings, can see whole menu and decide and alternative letter in the string but the menu can't have 2 options with same letter for shortcut key. I myself have such problem where half the strings lost the shortcut key. I am almost finishing translating but translating is just the initial step. Then I will have to make lots and lots of corrections like the shortcut keys and make half of them to use other letters. We are not forced to use the same letter as the English version.

Now... I just would like to have mpc-hc translation online editor to tell me the max width of the string because some strings will be broken when displayed and theses strings will need to be shorten.

[lychichem]

lychichem hit a problem when Chinese and other languages don't use the normal 26 alphabet letters. Putting the shortcut letter between ( and ) with & is a good move. I must say the key shortcuts for menu are hidden since ... XP(?)... maybe Vista and the user needs to have the option enabled to see them or when in a dialog an ALT will make them visible. If the key shortcut can't be used, people which are translating strings, can see whole menu and decide and alternative letter in the string but the menu can't have 2 options with same letter for shortcut key. I myself have such problem where half the strings lost the shortcut key. I am almost finishing translating but translating is just the initial step. Then I will have to make lots and lots of corrections like the shortcut keys and make half of them to use other letters. We are not forced to use the same letter as the English version.

Now... I just would like to have mpc-hc translation online editor to tell me the max width of the string because some strings will be broken when displayed and theses strings will need to be shorten.

Yes, certainly nobody force the translation usse the same shortcut, but for other l10n projects, usually the shortcuts are kept same. So not changing shortcut may be an arrangement.

As for strings max length, I have to tell you sadly that nearly no online platform can tell you. Some even can't tell you where the string will be displayed. I've tried manually calculate how many characters can be included in the display area by dividing item width/height givien in the resource files of the program and characters width/height. It's painful so I don't suggest you to do so like me. Maybe an improved string extractor which can extract the string as well as the position and size of its container will solve the problem (but I'm unable to make one for you).

[moonlightz]

1 way is to manually generate the dll file and check manually which are splitted to the next line and shrink strings as musch as possible. Checkboxes and labels usually split to the next line but if the height is not high enough, the rest of the text is not visible.

[clsid2]

I'm afraid that removing & will cause translated versions of MPC-HC lost the menu shortcut function. The best way is to use a (&) at the end of translated string. For example, &Play will be 播放(&P) after translated to Simplified Chinese.

Please just remove menu shortcuts instead of adding letters behind the translations. Almost nobody uses these shortcuts anyway. They aren't visible by default either as moonlightz already mentioned.

[adipose]

Transifex translations should be up to date as of today, including adding Portugal. Future updates will continue to come in every few weeks when I notice some additions. When adding a new language I have to do a bit more work than just merging it, so be patient.

When it comes to string length, we went through a gui upgrade several months ago to allow much wider strings (particularly Russian) to fit where previously they could bleed outside the area. So most strings should fit fine if you keep the translation reasonable. For menus it should just expand to the string size.

As for shortcuts, I would focus on using ctrl/alt type shortcuts as much as possible. If you can keep the underlined char the same, great, but otherwise just eliminate it. The alternative is to review the entire menu or submenu and make sure all your shortcuts are unique (as possible).

[moonlightz]

I'm thinking of waiting for you to launch the pt-pt lang with next version of MPC-HC and then see the need of small corrections like proper context and shortening of some strings to fit and menu key shortcuts and that should take 1-2 days. I included & in some menu options and removed where there wasn't a compatible letter as mentioned in a post above. The & can be in some other letter as long as there is no duplicate in that specific menu. Very few people will see these menu keys and use them daily. Either remove all or adapt them to the other letters, I would say.

[adipose]

I can make a test build.

[moonlightz]

Sure, if you don't mind.

[adipose]

@moonlightz , here you go, based on the latest transifex import.

https://mega.nz/file/4YZ1WC4K#Q7Lq5THTFbt6yaBy31aMuvdBps3k_AVtpksvImgDXYo

[moonlightz]

It seems you need to do it again. For some reason, the import got the work around where I was at the middle of the translation.

[adipose]

I just imported the newest translations. Do you want another test build?

Are you saying the latest release didn't have the translations from the test build I made you?

[moonlightz]

Yep and yep.

[adipose]

https://mega.nz/file/JRgHwZbS#yEv077dwo6U2XbCxpQWTxAHQ6KU0h9NKxAlx-ukSC8I

This is built from the latest dev source. It should hopefully have all the updated translations.

[moonlightz]

Problems are still there. No idea what's wrong. It should appear as they are translated in transifex but some strings aren't. The Options dialog tree at left is messed up.

[adipose]

Can you send a screenshot of what it looks like, and what the right string should be?

[adipose]

@moonlightz , what is your transifex username?

[adipose]

Also the test build contains a lang folder with the language specific dlls. If you don't extract that, you won't get the update translations.

[adipose]

https://mega.nz/file/NApzDZxZ#UHFLf8tFJpOYRNT5lYCYSQEpoEhqOvf9L4Sa2_xoPps

Here's another test build. I see more strings that came through from pt_PT.

[adipose]

I can see some english in the left pane, and I'm checking into it.

[adipose]

After reviewing it, it seems you are missing some translations that have been set to English somehow.

Here is one example (hopefully this search works for you):

https://www.transifex.com/mpchc/mpchc/translate/#pt_PT/src-mpc-hc-mpcresources-po-mpc-hc-strings-pot--transifex/190719923?q=text%3A'playback%3A%3Aoutput'

This controls the title for "Output" here:

[moonlightz]

Doing a search for :: , can see some items I left untranslated on purpose thinking that the items would get replaced by another string calls. Even so, some strings were changed after and it's like I say, they got stuck in a previous wave of translation. I'm gonna translate those items with ::

[adipose]

It's possible I screwed up when merging them. You could go through the commits to that file and see if it was ever reverted. Or, you could just fix it.

I need to create a workflow that matches the transifex formatting, because every time a string is submitted, it alters the formatting of it, which creates confusing diffs for merging. It might have caused an error on my end.

[moonlightz]

Ok, I translated the items with :: . When I finished translation weeks ago, I made some changes after doing so. One of those changes was changing the string of Donate option menu from "Doar" to "Fazer uma doação", however, the translation you exported still had the first translation before correction.

[adipose]

I didn't get any new updates in the branch...hmm.

[moonlightz]

It seems I jumped some messages here... My transifer username is hugo.simoes.1984 And yes, I extracted everything using 7zip to a folder, I see a folder named Lang. I think no one mentioned this before but the underlined letters for shortcut keys of menus are invisible when dark theme is enabled.

[moonlightz]

Perhaps, I need to click on something... no idea. Heres a screenshot... Transifer should give you the strings that are showing at right, the ones I translated. And yes, Home Page could be translated but I left that one alone on purpose. Everyone here knows it will lead to the home page.

[adipose]

Something is wrong with the translations. I think it has to do with the :: and the strings that define the tree. Notice the tree branching has broken:

[moonlightz]

Yep, It seems broken, that's why I left the strings with :: alone in first place. The translations I made today seem to have broken the tree. Any solution? Should I replace back the strings with :: ?

[adipose]

No, I will review it.

[moonlightz]

heh... I've been thinking and I think I screwed up. I fixed the strings now... I think. The tree should be ok now.

[adipose]

https://mega.nz/file/UZgzjbhJ#CcTe70yREkVuynBzmmqN-aauHfsPa_8YejRP7H0GzUk

Yes, it looks good now. Here is a build from the transifex branch. If it looks good to you I will submit a PR.

[moonlightz]

Yeh, it's almost OK. There is a problem with "Internal filters", It's duplicated. Gonna try to fix the strings again.

[moonlightz]

I changed strings for Internal Filters and also made some more small corrections. I also changed Subtitles::Misc translation to something that means Subtitles::More settings, to not confuse with miscellaneous at end of the tree. Brazillian also changed that Subtitles::Misc string. Shaders is also a term that doesn't have a proper meaning for translation. Leaving it as is. Brazillian translation also left that as is. Hmm.. the braziilian translation looks messy... in some areas.. :P not my job to correct them. It should be ok now for a new release. But I'm guessing I'm not done yet.

[adipose]

https://mega.nz/file/4RwjgLJB#vKf8wAPN2OBB-gHAayxGyTjNLmZivPdmJD_7gKDckFc

New build.

[moonlightz]

Great! The tree seems ok to me. Most of the things are ok as well and like I said, it will still need more smallish corrections like to short or enlarge strings. It will go over the time.