Two Small Problems - 2.1.4

[Felipefpl]

Hi, i ran into 2 small problems with mpc:

1 - The Inno installer is using a REALLY old translation of an OLD inno setup's version. I'm not referring to the strings we can find on transifex. Could you please update the Inno's version so it'll use the newest translations for all languages?

2 - I saw the GUI was expanded in the commits with the submission of a pull request but there are places where the translated strings cant be seen such as this one:

There are other places where i cant see the translated strings and i'm sure this happens with other languages too since languages other than english usually contain bigger words or phrases.

[xLn2]

The UI page looked a little cramped. I made some adjustments. It probably doesn't solve some of your mentioned issues but there should be easy fix for them like shortening translation or making these issued options to multiline. Or other options which I don't know.

Today	Planned

• Improvements in the location of buttons depending on covered area, calculation distance between them.
• Editbox size and width decreased.
• Text areas expanded (which are able to)

IDD_PPAGETHEME DIALOGEX 0, 0, 356, 289
STYLE DS_SETFONT | DS_NOFAILCREATE | DS_FIXEDSYS | WS_CHILD
FONT 9, "Segoe UI", 400, 0, 0x1
BEGIN
    GROUPBOX        "Theme",IDC_STATIC1,6,6,170,60
    CONTROL         "Use Modern Theme",IDC_CHECK1,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,20,160,8
    LTEXT           "Modern Theme Color:",IDC_STATIC2,12,34,87,8
    COMBOBOX        IDC_COMBO1,102,32,70,47,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
    LTEXT           "Control buttons size:",IDC_STATIC3,12,50,126,8
    EDITTEXT        IDC_EDIT1,138,48,34,13,ES_CENTER | ES_AUTOHSCROLL | ES_NUMBER
    CONTROL         "",IDC_SPIN1,"msctls_updown32",UDS_SETBUDDYINT | UDS_ALIGNRIGHT | UDS_AUTOBUDDY | UDS_ARROWKEYS | UDS_NOTHOUSANDS | UDS_HOTTRACK,160,48,13,13
    GROUPBOX        "Seekbar",IDC_STATIC4,6,72,170,93
    LTEXT           "Modern Seekbar height:",IDC_STATIC,12,86,126,8
    EDITTEXT        IDC_MODERNSEEKBARHEIGHT,138,84,34,13,ES_CENTER | ES_AUTOHSCROLL | ES_NUMBER
    CONTROL         "",IDC_MODERNSEEKBARHEIGHT_SPIN,"msctls_updown32",UDS_SETBUDDYINT | UDS_ALIGNRIGHT | UDS_AUTOBUDDY | UDS_ARROWKEYS | UDS_NOTHOUSANDS | UDS_HOTTRACK,160,84,13,13
    CONTROL         "Hover:",IDC_CHECK8,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,102,75,8
    COMBOBOX        IDC_COMBO3,88,100,84,64,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
    LTEXT           "Hover type:",IDC_STATIC8,12,118,75,8
    COMBOBOX        IDC_SEEK_PREVIEW,88,116,84,47,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
    LTEXT           "Preview width (% of screen)",IDC_STATIC7,12,134,126,8
    EDITTEXT        IDC_EDIT4,138,132,34,13,ES_CENTER | ES_AUTOHSCROLL | ES_NUMBER
    CONTROL         "",IDC_SPIN2,"msctls_updown32",UDS_SETBUDDYINT | UDS_ALIGNRIGHT | UDS_AUTOBUDDY | UDS_ARROWKEYS | UDS_NOTHOUSANDS | UDS_HOTTRACK,160,132,13,13
    CONTROL         "Show chapter marks on seekbar",IDC_CHECK2,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,150,161,8
    GROUPBOX        "Status Bar Elements",IDC_STATIC10,6,171,170,71
    CONTROL         "Track Language",IDC_CHECK3,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,185,114,8
    CONTROL         "Video Info",IDC_CHECK4,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,199,114,8
    CONTROL         "FPS",IDC_CHECK5,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,213,114,8
    CONTROL         "A-B Marks",IDC_CHECK6,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,227,114,8
    GROUPBOX        "Language",IDC_STATIC21,6,248,170,30
    LTEXT           "Language:",IDC_STATIC5,12,262,82,8
    COMBOBOX        IDC_COMBO2,88,260,84,20,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
    GROUPBOX        "On Screen Display (OSD)",IDC_STATIC9,181,6,168,60
    CONTROL         "Show OSD (requires restart)",IDC_SHOW_OSD,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,187,20,161,8
    LTEXT           "Font:",IDC_STATIC6,187,34,80,8
    COMBOBOX        IDC_COMBO5,225,32,120,61,CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_TABSTOP
    LTEXT           "Font size:",IDC_STATIC23,187,50,80,8
    COMBOBOX        IDC_COMBO6,315,48,30,61,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
    GROUPBOX        "Window Behavior",IDC_STATIC,181,72,168,57
    CONTROL         "Limit window proportions on resize",IDC_CHECK7,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,187,86,161,8
    CONTROL         "Snap to desktop edges",IDC_CHECK9,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,187,100,161,8
    CONTROL         "Hide Windowed Controls",IDC_CHECK10,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,187,114,161,8
    GROUPBOX        "Windows Integration",IDC_STATIC,181,135,168,43
    CONTROL         "Use enhanced taskbar features",IDC_CHECK_ENHANCED_TASKBAR,
                    "Button",BS_AUTOCHECKBOX | WS_TABSTOP,187,149,161,8
    CONTROL         "Control via Windows UI (SMTC)",IDC_CHECK11,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,187,163,161,8
END

[adipose]

Is it actually taller or is that just an artifact of the screenshot?

[xLn2]

One of screenshoot taken from compiled mpc-hc the other one is from vs2019 resource editor. Page size is same but maybe it is streching with pagetree view or just dpi(125%) issue. I might both take screenshoots from vs2019 but somehow I thought it looks narrowed for text spaces for clarity.

[xLn2]

@adipose Can you try my changes when you are available?

After the adjustment there will be probably still some issues afaik these 3 languages (Bulgarian, Greek, Portuguese(Brazil)), there are some things that need to be checked, some of which should be done by the translators:

1. Excessive fidelity to the original text (thus text does not fit in the relevant field):

i.e.: Show chapter marks on seekbar can also translateble as Show chapter marks

2. Showing options as tooltip which do not fit text

3. "Font" takes much space for Greek translation "Γραμματοσειρά:" and cause not fit specified area

Narrowing the font options box and expanding it according to the its content may solve the problem.

4. For texts that do not fit due to lack of space, we can wait for the translators to get back to us. Perhaps nothing better may be possible on the translation side.

---

In current versions, even the text that should normally fit does not fit. It can be observed more clearly in Modern light and classic themes. In the modern dark theme, text borders are not taken into account.

[adipose]

Is number two complete?

For number 1, I don't quite understand what's wrong. Can you post some screenshots? I tried some other languages and they seem ok.

[clsid2]

1 is already taken care of.

[Felipefpl]

2 - Still needs improvement, i can see the text fully written in the drop-down box but not in the right side, see pic below:

[adipose]

Just was posting this. It's better but there are areas that don't have room and can't easily be fixed without expanding layout.

[clsid2]

You will have to shorten the translations. Like remove "(SMTC)" part which is English abbreviation of the relevant Windows API.

[adipose]

For hover type at least, I can enable dynamic sizing of the combo:

https://github.com/clsid2/mpc-hc/pull/2815

[xLn2]

I don't want to sound overly demanding, but I would like to add the followings, which I think is quite relevant to the issues.

1. "Control buttons size" doesn't seen on various languages

2. Vertical alignment of Static Text -- ControlBox (currently it looks like aligned top but most of the places in app it aligned centered/middle)

3. "Display Current T&ime" string might be changed to "Display Current Position" but I am not sure about that since my English not that good.

[adipose]

1. Fixed
2. An illusion

[adipose]

It can be improved. Comboboxes height cannot be controlled, but static height can, so I can make it close. Looks like combobox naturally has an extra pixel on the bottom in 175% mode. But by setting the static height to the closest possible, the text lines up when centered vertically.

I'll review other forms and improve them.

[xLn2]

Considering the age of the MPC-HC, different design approaches have been applied in different times and places before. Maybe I may have accepted the one that appeals to my eyes as correct by being selective in perception. Since static and controlbox are not usually used together, I took a look at the Playback>Capture section, which I thought was one of the first ancient examples, then I noticed that in the Playback>zoom and alignment block and in a few other places, the texts (Static and Controlbox) were tried to be mapped vertically. Although MPVCR is not an internal project, seeing the same approach there may have affected my visual approach.

In the past, I have been unable to untangle several design complexities and have attempted small “improvements”, but a broader perspective and a comprehensive intervention would eventually be needed. Even though “Subtitles>Default Style” is on the same page, the size of the editboxes and even the distances between them are different.

It seems like all this could be covered in a separate comprehensive “GUI Design” issue, but I think there is no need to rush into this yet.

[adipose]

See https://github.com/clsid2/mpc-hc/pull/2815 for some dynamic alignment improvements.