clsid2 / mpc-hc

Media Player Classic
GNU General Public License v3.0
11.5k stars 500 forks source link

MPC Video Renderer: Bug reports, feedback, and discussion #2870

Closed clsid2 closed 1 month ago

clsid2 commented 5 months ago

In this topic you can discuss issues with MPC Video Renderer.

Answers to frequently asked questions

Read this first: FAQ

Official bug tracker

https://github.com/Aleksoid1978/VideoRenderer/issues

That is also the place to make feature requests.

MadokaAyukawa commented 5 months ago

I have R set to Reload Subtitles. I produce and edit subtitles. After an edit I will tap R to reload the subtitles in MPC-HC to check that it looks correct. This worked fine for many years with EVR (Custom presenter) with either the internal subtitles handler or libass. This also works fine with MPCVR and the internal subtitle handler.

However, after a few reloads using MPCVR and libass, the video will freeze in full screen or windowed mode. The audio will still play. I will have to have Windows close the program. It can happen on the first reload or after one or two reloads.

image

clsid2 commented 5 months ago

It is due to call to ConnectionMediaType() in CMainFrame::UpdateSubtitleColorInfo(). Triggers a deadlock in MPCVR. Also happens without libass.

Edit: fixed

Raccffy commented 5 months ago

Playing a video with BT.2020 transfer primaries and BT.2020 non-constant matrix coefficients cause input format text go out of the background.

More specifically, second indented line in the "Input format" block is very long.

Zero is out of bounds.

Dantrigger commented 4 months ago

Quick question, does the renderer support Dolby Vision playback for BDMV rips? Or DV is only supported in MKV and MP4 formats?

clsid2 commented 4 months ago

Try it and find out.

It does not support DV variants that use extension layer.

DumbIdiot commented 4 months ago

When I use MPCVR with Hardware Device to use in LAV Video Decoder set to Automatic (Native), 4K 60 FPS videos only play at around 40 FPS and causes the video to get out of sync with the audio. If I set it to my specific graphics card (and forces copy-back) it seems do play fine. With madVR both of these settings perform the same. Is this expected behavior?

Dantrigger commented 4 months ago

Try it and find out.

It does not support DV variants that use extension layer.

Thanks for the reply, I hadn't realized that CTRL+J worked to show video statistics. And as I thought, BDMV rips with enhancement video layer only play the HDR10 layer. Looks like there is still no solution to get full DV Profile 7 support in PC, and by the looks of it, it will never happen.

clsid2 commented 4 months ago

When I use MPCVR with Hardware Device to use in LAV Video Decoder set to Automatic (Native), 4K 60 FPS videos only play at around 40 FPS and causes the video to get out of sync with the audio. If I set it to my specific graphics card (and forces copy-back) it seems do play fine. With madVR both of these settings perform the same. Is this expected behavior?

In Windows Settings App, in advanced display settings, you can specify the preferred GPU that should be used by MPC-HC (and other individual apps). You did not mention which GPUs you have, so I can't comment on the problem itself. Likely your integrated one has poor performance.

DumbIdiot commented 4 months ago

In Windows Settings App, in advanced display settings, you can specify the preferred GPU that should be used by MPC-HC (and other individual apps). You did not mention which GPUs you have, so I can't comment on the problem itself. Likely your integrated one has poor performance.

I have an RTX 2070 Super and a Ryzen 3700X which doesn't have any integrated graphics so I only have the one 2070 Super to select as my device. In the Windows settings it only gives me "Power saving" and "High performance" options for the 2070 and they both perform as described with D3D11 Automatic (Native) selected in LAV. D3D11 Copy-Back works fine but I was under the impression that Native is supposed to perform better than Copy-Back.

clsid2 commented 4 months ago

That one should work fine with native mode. Maybe try different version of NVIDIA driver.

Press Ctrl+J and make a screenshot.

DumbIdiot commented 4 months ago

The first few seconds plays fine but then the frame rate drops and the sync offset shoots up.

Screenshot 2024-07-23 194527

I don't know much about video playback so maybe I have a misconfiguration somewhere.

Screenshot 2024-07-23 194622 Screenshot 2024-07-23 194638

I'm only 1 or 2 updates behind the latest Nvidia driver but I'll try updating and if it doesn't fix anything I can just use copy-back for the time being.

Epidemilk commented 4 months ago

I'm getting weird crashes in fullscreen mode. Windows 11, NVIDIA 4060. Displays completely cut out, unresponsive to mouse/keys, sometimes the audio will keep playing, and I have to force power down.

Even out of fullscreen, sometimes the video will freeze and audio continues, but at least then I can just close it and try again.

It's been problematic for the last few versions- what settings should I tinker with?

clsid2 commented 4 months ago

If graphics driver crashes you need to try different version of the driver.

Win+Ctrl+Shift+B is Windows shortcut for restarting driver.

Epidemilk commented 4 months ago

I'm on the most current NVIDIA driver, not sure what else I should be trying?

clsid2 commented 4 months ago

Most current driver is not necessarily the best one. NVIDIA drivers are full of bugs. There are literally dozens of previous drivers that you can try.

Epidemilk commented 4 months ago

I sniffed around a little, went in my display settings, changed some power management setting I know forget and turned off vertical sync, seems okay now!

Joe2500 commented 4 months ago

how do i hide the file name that appears for several seconds when opening a video? i can't find anything related to it in the settings.

clsid2 commented 4 months ago

options > player > user interface > uncheck show OSD

fcueto commented 3 months ago

When I play DV content using mpc-hc 2.3.4 it is working and improves image quality considerably, but... it stops working in full-screen mode unless the seekbar is showing.

clsid2 commented 3 months ago

Convert to SDR should never be unchecked. It only converts when passthrough is not possible.

For problem: Make screenshot with Ctrl+J overlay enabled. Post issue here: https://github.com/Aleksoid1978/VideoRenderer/issues

xenrohachi commented 3 months ago

I recently ran into a similar issue and it ended up being image scaling in the nvidia 3d settings. Even if it’s only enabled on one game/profile and not universally, it’ll still cause HDR to work only when the seek bar is active.

IIIelKot commented 2 months ago

I have a question about HDR playback. I have HDR in Windows enabled permanenty, monitor report that it's in HDR mode, games in HDR run without "screen go black for a (few) second", HDR video in windowed mode does the same. But when i switch to fullscreen mode - "screen go black", when MPC ui is displayed over (osd, seekbar) - "screen go black", when it dissappears - "screen go black", when Windows displayed over (win+g, alt+tab) - "screen go black". And all that time Ctrl+J indicates that the videoframes are in HDR. Can something be done with that behavior?

clsid2 commented 2 months ago

I can only suggest to complain to your graphics driver vendor about it.

Salem226 commented 1 month ago

Press Ctrl+J to show debug overlay and make new screenshot.

Disable RTX HDR and SuperRes. 3

Screenshot 2024-10-14 152535

clsid2 commented 1 month ago

Look in Intel graphics settings. Maybe something is wrong there.

I can not help you any further.

If problem only happens with this specific video, then the file is probably just badly encoded.

Salem226 commented 1 month ago

Look in Intel graphics settings. Maybe something is wrong there.

I can not help you any further.

If problem only happens with this specific video, then the file is probably just badly encoded.

who can help me?