clsid2 / mpc-hc

Media Player Classic
GNU General Public License v3.0
11.5k stars 502 forks source link

add FullScreenSeparateControls to fullscreen page #3139

Closed adipose closed 1 month ago

clsid2 commented 1 month ago

Screenshot?

You can leave the advanced option active for now, in case people look for it there. It can be removed in future.

adipose commented 1 month ago

image

clsid2 commented 1 month ago

What do you think about "Allow separate control window" instead of "Show ..."? Or maybe "Use ..."?

adipose commented 1 month ago

I like "Allow" as it is not guaranteed to show up unless you have a second monitor.

Btw I did add the hover info there.

image

clsid2 commented 1 month ago

Agree that "Allow" is better.

Also, are there many translation updates yet? I plan do a 2.3.7 release this weekend, but can wait a few days if needed.

adipose commented 1 month ago

Let me see about the translations.

adipose commented 1 month ago

I noticed something in the translations merge. Hotkey was removed which is breaking "good" translations:

image

I could probably save all these by removing the ampersand.

clsid2 commented 1 month ago

Yeah, I removed ampersand because it caused a ugly draw artifact in options gui.

adipose commented 1 month ago

Do you want me to save the existing translations and just remove the ampersand?

clsid2 commented 1 month ago

Yes please.

In the chinese example above the whole (&I) can be removed.