clssn / numato-gpio

Python API for Numato GPIO Expanders
MIT License
4 stars 6 forks source link

Simplify reading from the device, ignoring end-of-line characters #36

Closed clssn closed 7 months ago

clssn commented 7 months ago

Reading from the various device variants got overly complicated with all the variants. It just occurred to me that the EOL sequences don't play any role, they are just there for better readability in a screen session with a human.

Remove EOL characters during low-level reading Remove any other EOL related code except the \r in queries Unify queries so to always read until the next prompt character (>) Validate port lengths in port length related queries

clssn commented 7 months ago
clssn commented 7 months ago

According to user feedback from Numato related HA core issues (here and here) this looks very promising.