cltk / capitains_corpora_converter

Converts CapiTainS-based Repository ( http://capitains.github.io ) to JSON for CLTK
MIT License
0 stars 1 forks source link

Writing non-ascii characters as is without escaping #8

Closed suheb closed 8 years ago

suheb commented 8 years ago

Signed-off-by: Suhaib Khan suheb.work@gmail.com

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 51.304% when pulling 94153a090474576fd397840808d4af65030d342d on suheb:fix/non-ascii into e311b09d2cdacd31c7a272c13e146bca4ef29b6e on cltk:master.

kylepjohnson commented 8 years ago

@PontelIneptique this change to writing Unicode makes sense for our current frontend. I'll merge this but let us know if you dislike writing JSON as utf-8.

PonteIneptique commented 8 years ago

Totally fine with this. Sorry for slow reaction

kylepjohnson commented 8 years ago

No, you were not slow at all! I wanted to merge the fix for Suhaib, so as not to delay his development.