cltorresfe / members

0 stars 0 forks source link

164 send email #167

Closed cltorresfe closed 8 years ago

cltorresfe commented 8 years ago

PR para #164

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 89.286% when pulling 1275333651c1083b355f8cf13c8f69e2c033d109 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-43.7%) to 45.44% when pulling d3b4a768fc6af05e4df9be2f695c8b4bad79d67e on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.7%) to 88.445% when pulling 2baa5c045ab3e1a878167b9a6fe6266047e8b42a on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 89.331% when pulling c9e1b0f837f025d800415f531378498a574665ad on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

alagos commented 8 years ago

@cltorresfe Bah, acabo de cachar que comenté en un código antiguo y que la validación la estás haciendo a nivel de js. De todas formas hay una validación a nivel de controlador que no se está testeando. Si no puedes pasar a través del test de feature, podrías hacer un test de controlador para ese caso específico en el que no va un subject como parámetro. Lo otro, ¿es muy complejo validar con ckeditor que venga texto en el body? ¿O se puede hacer con el jquery validator?. Igual podrías poner la validación a nivel de controlador de si viene o no el body.

alagos commented 8 years ago

@cltorresfe recuerda de clickear los checkboxes que hayas realizado en el issue para saber cuando esté listo el PR de hacer el merge

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 89.54% when pulling 61b176e5ee0ac4b985e678c245984063e2d9bd11 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 89.54% when pulling 61b176e5ee0ac4b985e678c245984063e2d9bd11 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 89.605% when pulling 90950853209dccf957f4d08f01385e7f02070179 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 89.605% when pulling 90950853209dccf957f4d08f01385e7f02070179 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.01%) to 89.189% when pulling 5579d5e9d781836afd2e6875ab885933deb0e233 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 89.605% when pulling bf0177a7a0536d011168e0746efaa53be32caac1 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.4%) to 89.605% when pulling 3d0dcb4075e39c00a6ae6e813e9e984b256df359 on 164-send-email into fa33287b2c5fa3d5cb2a4edbb1cb4887c9f2f041 on master.