search

club-1 / flarum-ext-cross-references

Add cross reference links when a discussion is mentioned from another one.
GNU Affero General Public License v3.0
6 stars 1 forks source link

Incompatible with Flags extension #5

Closed hrvoje-hr closed 1 year ago

hrvoje-hr commented 1 year ago

This extension is incompatible with the default Flags extension. Tested in the production forum and on the freshly installed instance as well.

When a post is flagged, all remaining posts in that discussion are invisible and the Scrubber is unusable.

With Cross-references enabled:

2022-12-15 12_01_43-asdad - Testni flarum

Disabled:

2022-12-15 12_02_26-asdad - Testni flarum

JS Console errors:

mount-redraw.js:15 TypeError: Cannot read properties of undefined (reading 'view')
    at render.js:141:24
    at render.js:160:3
    at c (render.js:66:8)
    at l (render.js:50:5)
    at render.js:134:5
    at c (render.js:63:14)
    at l (render.js:50:5)
    at render.js:134:5
    at c (render.js:63:14)
    at l (render.js:50:5)
n-peugnet commented 1 year ago

Thanks, in fact this is already fixed in master by 6c9583402821bcedc17ab04c69e3a925112d804b

I will make a release right now with this change!

n-peugnet commented 1 year ago

Released in v0.4.0 (it may not be downloadable right away with composer)