club-1 / webdav-drive

WebDAV Drive is a file explorer running in a web browser that adds a Google-Drive-like experience to an existing WebDAV share
GNU General Public License v3.0
17 stars 4 forks source link

Upgrade to Carbon Components Svelte v1.0.0 #66

Open n-peugnet opened 10 months ago

n-peugnet commented 10 months ago

This is a major change to Carbon Components Svelte as it also upgrades the Carbon stylesheet from v10 to v11. It is not released yet, but we can already try to see if anything breaks or if we will need to change some things.

See https://github.com/carbon-design-system/carbon-components-svelte/discussions/1614

Svelte projects consuming carbon-components-svelte will need to include SCSS preprocessors.

This is interesting as it will allow use to fix #58 in a proper way, as I imagined initially, by setting the $font-path parameter to an appropriate value. This in turn will allow to get rid of rollup-plugin-bundle-fonts introduced in https://github.com/club-1/webdav-drive/commit/635ad42ac7d8bae02e4c1e2d5e18fb330b8720be, and probably also the commonjs loader as I think it is the only non ES module of the project (and newer project are almost all ES modules).