Editing brand pages - Githubissues

jessyclubsoda commented 5 years ago

This is a follow on from #522

On the live site, one of our admins encountered a bug when updating The Bitter Note brand member page. When she edited and saved the page, the images associated with the brand disappeared. She then went back into the editing and refreshed the page and the banner image appeared but not the image associated with the drink itself.

I went onto staging to try and recreate this bug:

I started out on the Heineken page which was as expected - filled out with a banner photo, description, copy etc. I went and edited the description. On saving with the edited description, all of these things disappeared. I am now unable to add a photo back to this brand.

Decided to try and recreate with a new brand to figure out the conditions under which this might be happening. Created Jessy's drinks and was able to upload a photo Edited the description and had no issues

Went back to look more closely at Heineken and realised that it was no longer a member. Once I changed this back - everything went back to normal

So from this I learned

Sometimes when the brand pages get edited, the member button gets unticked (but not all the time because it didn't happen to Jessy's Drinks)
It is not that all of the buttons get unticked when an edit gets made because Heineken still kept all of its retailers which is the same style of button
And regardless of all of this I couldn't recreate the drink image disappearing as it did for The Bitter Note

Any thoughts about what might be happening?

nelsonic commented 5 years ago

@jessyclubsoda thank you so much for adding this insightful issue report it helped us figure out the problem. @RobStallion please see https://github.com/club-soda/club-soda-guide/pull/590 thanks! ✨

nelsonic commented 5 years ago

@jessyclubsoda we think we have identified and fixed the issue with the brand banner image. Please re-test on staging: https://club-soda-guide-staging.herokuapp.com/brands/heineken Thanks. 🌈

jessyclubsoda commented 5 years ago

Just confirming that basically this now means that we don't have to check whether brands are members or not? We will automatically get the option to add in the extra details for them and can just choose to do this for the relevant ones?

It's all looking good!

iteles commented 5 years ago

@jessyclubsoda I'll add a member vs non-member section to the docs as well!

club-soda / club-soda-guide

Editing brand pages #578