clubcapra / ovis

Ovis robotic arm control package
0 stars 1 forks source link

Ovis package rewrite for GPA791 #20

Closed lit-af closed 4 years ago

lit-af commented 4 years ago

Complete rewrite of the Ovis support package. While work isn't 100% complete, this branch is good enough to overwrite the current master branch.

Overview of work done:

lvanasse commented 4 years ago

Ouf, this is a really big PR and with little documentation. Everything seems good but I definitely didn't understand all of it.

My advice would be: try to do a PR per issue that you close. Or maybe 2 max if they are closely related. If possible, I would like to have a bit more description of how the overall program works and how to test most parts? (I saw that ovis_description does have a README, but the other doesn't seem to have any)

You seem to have conflicts with your master branch. If you don't need those files anymore try deleting them in your PR.

Also, I see that you have many branches some are stale and the active ones date from one month ago. If you could also maybe clean up those branches would be nice.