search

clubcapra / takin

:goat: Capra-Takin is a ROS-based solution for managing and operating Club Capra's rescue robot. :sheep:
GNU General Public License v3.0
6 stars 3 forks source link

Estop pub fix #80

Closed lit-af closed 5 years ago

lit-af commented 5 years ago

Travail fait : Added a while(ros::ok) loop. Added the latch argument to the estop status publisher #78

Est-ce que ça été testé et comment? : Besoin de tester sur le robot?

lvanasse commented 5 years ago

Why do you want to push code into master that you don't even know works? What are you trying to accomplish? You don't need it to be inside the master for it to be tested.

lit-af commented 5 years ago

It launches just fine on my computer, but since the node uses a library specific to the Jetson. It can't open the GPIO therefore, it can't publish anything.

lit-af commented 5 years ago

@Ludoenso Freeze this branch before testing. So that we're on the same page as to what has been tested? Please advise if there's an other way you'd like me to do that.

lvanasse commented 5 years ago

@Ludoenso Freeze this branch before testing. So that we're on the same page as to what has been tested? Please advise if there's an other way you'd like me to do that.

The e-stop is just not tested, at least try it on the robot. And also you're still missing code...

lvanasse commented 5 years ago

It launches just fine on my computer, but since the node uses a library specific to the Jetson. It can't open the GPIO therefore, it can't publish anything.

Right, I thought that if you cannot access the GPIO pin, you would send false. Even tho that not the behaviour that you want, you could of test your publisher by sending false if it can access the pin.