search

clubgamma / Twitter-Web-Clone

Official Hacktoberfest 2021 project repository from Club Gamma. Start hacking!
https://clubgamma.github.io/Twitter-Web-Clone/
6 stars 13 forks source link

Fix Animation on Messages popup #31

Closed KishanSeksaria closed 2 years ago

KishanSeksaria commented 2 years ago

-[X] I have read the Code Of Conduct. -[X] I have followed all the steps of submission properly.

Fixes #24 Changed expansion/popup animation of bottom right floating messages section on click.

Before initial

After final

*Most of the changes are due to the code-formatter in my editor

poojanV55 commented 2 years ago

Hello @KishanSeksaria , Can you please check the popup once again which is when closed it is seemed to be half expanded .

(When closed) image

(when expanded) image

KishanSeksaria commented 2 years ago

Ok i will check it, maybe i hard coded the value

KishanSeksaria commented 2 years ago

I think it works fine now. Can you please check? @poojanV55

poojanV55 commented 2 years ago

@KishanSeksaria Can you create the pr in a new branch with the name of the feature as it is clashing with main branch.

You can read contributing.md for the same in which it is mentioned.

KishanSeksaria commented 2 years ago

Ok sure