Closed Reterics closed 1 week ago
minimum prs filter not working
The original count: prNumbers implementation needed to be changed to counting the prs.
Since Prisma ORM doesn't support filtering directly by the aggregated count in the findMany function, I applied the filter and pagination after the findMany. I tested and it seems to be working.
Note: The code could be greatly simplified/speeded up if the prs number variable was added to webhook/github.js. (In this case the pagination could be put back intoPrisma, and the API call would be faster, but this is an another optimalization ticket)
The original count: prNumbers implementation needed to be changed to counting the prs.
Since Prisma ORM doesn't support filtering directly by the aggregated count in the findMany function, I applied the filter and pagination after the findMany. I tested and it seems to be working.
Note: The code could be greatly simplified/speeded up if the prs number variable was added to webhook/github.js. (In this case the pagination could be put back intoPrisma, and the API call would be faster, but this is an another optimalization ticket)
agree, create a separate issue then.
Changed the leaderboard API to
{contributors:[], meta:{currentPage: number, totalPages: number, totalUsers: number,}}
With this update the Issue 21 in the Frontend needs only minor changes, and will be easier to maintain.