Craft 4 Support - Githubissues

clubstudio / craft-asset-rev

A Craft CMS plugin to help with cache busting

MIT License

109 stars 7 forks source link

Craft 4 Support #31

Closed mattstein closed 2 years ago

mattstein commented 2 years ago

Hi! 👋

This PR adds Craft 4 support.

Seems to be working fine, only downside is I removed your FilenameRevTest because assertAttributeEquals() doesn’t exist in PHPUnit 9. (They removed methods for testing non-public attributes.) The remaining tests pass, however.

scottwakefield commented 2 years ago

Hey @mattstein,

Thanks so much for this. I'll take a look over the changes early next week and get it merged in.

👍🏻