clubstudio / craft3-asset-rev

A Craft 3 plugin to help with cache busting
MIT License
7 stars 3 forks source link

Call to a member function setAttributes() on null #2

Closed Danetag closed 7 years ago

Danetag commented 7 years ago

Hello,

When I override the basic config with config/assetrev.php, I get this error:

screen shot 2017-05-04 at 3 27 39 pm

config/assetrev.php

<?php
return array(
    'manifestPath' => '/web/static/assets.json'
);

Am I doing anything wrong here?

Thanks!

scottwakefield commented 7 years ago

Hi @Danetag,

Ahh, there were some changes in Craft 3 beta 8 that changed the way that settings are handled. A pull request updated the plugin, but a new release wasn't tagged, so you've likely got an outdated version of the plugin.

If you update your composer.json to so the plugin require statement looks like this "clubstudioltd/craft3-asset-rev": "^1.0.0" and then run composer update, it should pull in the latest version.

Let me know how you get on.

Thanks for reporting the issue! Much appreciated.

Scott

Danetag commented 7 years ago

Hi @scottwakefield !

Thank for the quick reply. I actually configured the composer exactly this way already ("clubstudioltd/craft3-asset-rev": "^1.0.0") and I have the issue.

Any chance you push a new release? 🏅

Thanks!

UPDATE: Oh wait you just did 👍 Thanks!

scottwakefield commented 7 years ago

Hi @Danetag,

New release is already pushed, so composer update should do the trick. Is it not pulling it in?

New release at: https://github.com/clubstudioltd/craft3-asset-rev/releases/tag/1.0.1

👍

scottwakefield commented 7 years ago

No worries @Danetag! Hope the plugin serves you well 👍