search

clue / docker-adminer

Adminer docker image, a full-featured database management tool for the web
66 stars 39 forks source link

Migrate to official php image #13

Open mikehaertl opened 9 years ago

mikehaertl commented 9 years ago

I see that instead of an official PHP base image this project uses a custom setup with nginx + php-fpm which requires supervisord to manage both services. So this is not in line with the recommended docker paradigm of one process per container.

It also seems to slow down the shutdown of this image. In a setup with 5 containers, it's always adminer that I have to wait for.

So would you consider a migration to the official apache based PHP image? It would make the Dockerfile simpler and take the burden of installing PHP from you. You still can tweak the PHP config though, if you want to.

mikehaertl commented 8 years ago

@clue Any opinion on this?

mathroc commented 8 years ago

There is now an official image based on alpine (eg php:7.0-fpm-alpine), so it could solve #16 at the same time

clue commented 8 years ago

There is now an official image based on alpine (eg php:7.0-fpm-alpine), so it could solve #16 at the same time

Sounds good to me! :+1:

Does anybody feel like filing a PR?

mikehaertl commented 8 years ago

@clue Good to hear! I think, this image can be simplified a lot. E.g. we should not need any supervisor at all. Using the official apache based PHP image it's only a matter of downloading the adminer source. That should also greatly improve startup/shutdown times.

clue commented 8 years ago

this image can be simplified a lot.

That's good to hear and I'm not opposed to getting any optimization in here at all :) This image has initially been created way before official PHP images were a thing. Now let's address these outstanding PRs :shipit: