search

clue / phar-composer

Simple phar creation for every PHP project managed via Composer
https://clue.engineering/2019/introducing-phar-composer
MIT License
855 stars 78 forks source link

Composer path with spaces bugfix #126

Closed dnquinn closed 2 years ago

dnquinn commented 2 years ago

Probably it works on linux environment, but on windows, if composer's executable file located by path that includes the spaces, command can't be executed. So this small fix should will prevent this error.

dnquinn commented 2 years ago

In my case its stops with this type of error.

'C:\Program' is not recognized as an internal or external command, operable program or batch file.

clue commented 2 years ago

@dnquinn Thank you for looking into this and filing this PR!

Your changes look very reasonable and I've indeed encountered a similar issue a few weeks ago. As a starting point, I've just filed #127 to address the build error, I'll look into this again once this addressed.

dnquinn commented 2 years ago

Thank you for nice lib. I've tried to solve the problem quickly as i can and only for my environment. So i am not suprised about failing the tests. Maybe you find more elegant way to fix it.

clue commented 2 years ago

@dnquinn Thank you, this has now been fixed via #128 (and #129) and I'll make sure to get this shipped asap! :shipit:

I hope this helps! :+1: If so, consider supporting this project, for example by becoming a sponsor ❤️