Open bosunski opened 4 years ago
@clue I'm thinking 🤔 since the Hijak
feature is still part of the /exec/{exec}/start
API and only surfaces when the Hijak is configured, we can just have the execStartStream
return a DuplexStreamInterface
which, as you've said, will cover for the ReadableStreamInterface
also.
I initially added execStartStreamUpgrade
as a public interface, but I noticed the same parameters are being passed for it as well as execStartStream
which is more like some repetition there. Which lead me to merge the 2 methods.
clue/reactphp-buzz
comes to play)Summary of changes
$hijak
parameter toexectStartsStream
$hijak
Example Usage