search

clue / reactphp-docker

Async, event-driven access to the Docker Engine API, built on top of ReactPHP.
https://clue.engineering/2019/introducing-reactphp-docker
MIT License
108 stars 16 forks source link

Use reactphp/async instead of clue/reactphp-block #77

Closed dinooo13 closed 1 year ago

dinooo13 commented 2 years ago

Found something to upgrade 🐳!

See https://github.com/reactphp/async

Ref: https://github.com/clue/reactphp-block/pull/67, https://github.com/clue/reactphp-block/issues/68, https://github.com/reactphp/http/pull/464 and https://github.com/clue/reactphp-mq/pull/34

dinooo13 commented 2 years ago

Oh.. it was a bit late when I did this and I used multiple selections to do the edits, now everything should be resolved thanks for the review 👍🏼

dinooo13 commented 2 years ago

Added a timeout to the ci.yml because the tests on 8.1+ seemed to run endless.

SimonFrings commented 2 years ago

I stumbled over this behavior in reactphp/socket#283, some tests got stuck in execution because of other tests that didn't close their servers/connections. Seems like this is the same case here. I would suggest we look into this in a different pull request, afterwards we can come back to this one.

dinooo13 commented 2 years ago

I will look into your solution and open a new PR to fix this 👍🏼

SimonFrings commented 2 years ago

@dinooo13 Nice work with #79, now that this one is merged we can rebase these in here changes and get this shipped 🎉

dinooo13 commented 2 years ago

Should be ready now :shipit:

dinooo13 commented 2 years ago

Both removed 👍🏼

dinooo13 commented 1 year ago

Fixed 👍🏼