search

clue / reactphp-docker

Async, event-driven access to the Docker Engine API, built on top of ReactPHP.
https://clue.engineering/2019/introducing-reactphp-docker
MIT License
108 stars 16 forks source link

Update tests to close any server sockets #79

Closed dinooo13 closed 2 years ago

dinooo13 commented 2 years ago

Close open connections in tests to prevent them from looping in the async update.

Based on https://github.com/reactphp/socket/pull/283

Ref: https://github.com/clue/reactphp-docker/pull/77

dinooo13 commented 2 years ago

I think this should do it for the async update. What do you think?

dinooo13 commented 2 years ago

@dinooo13 I tested this in my private fork together with your changes in https://github.com/clue/reactphp-docker/pull/77 and the tests for PHP 8.1 and PHP 8.2 don't get stuck anymore :+1:

I actually thought that this pull request would involve some bigger changes, that's why I suggested to open up an additional PR. I think this is good as it is, but if https://github.com/clue/reactphp-socks/pull/110 involves the same amount of changes we can just add a second commit in there.

In https://github.com/clue/reactphp-socks/pull/110 it's quite a bit more so I think the additional PR is the way to go 👍