search

clulab / corenlp-small

Stripped down version of CoreNLP
0 stars 0 forks source link

sbt publishLocal fails #2

Closed MihaiSurdeanu closed 3 years ago

MihaiSurdeanu commented 3 years ago

Hi @kwalcock,

On this project, sbt compile test works fine, but sbt publishLocal fails with compilation errors... Can you please look into this? I wonder if I the build.sbt is incorrect in some way? It is pretty generic right now.

Thanks!

kwalcock commented 3 years ago

If you get people trying to build this with sbt on Windows, they will have problems because some of the Java source files include Unicode characters and Windows does not default to UTF8. They might use

cmd> set _JAVA_OPTIONS=-Dfile.encoding=UTF-8

or

PS> $env:_JAVA_OPTIONS="-Dfile.encoding=UTF-8"

to make it work. Other users who might have changed their defaults would also have problems.

kwalcock commented 3 years ago

javacOptions ++= Seq("-encoding", "UTF-8") took care of the problem above. It will be in the PR.

MihaiSurdeanu commented 3 years ago

Thank you!

On February 5, 2021 at 10:43:01 AM, Keith Alcock (notifications@github.com) wrote:

javacOptions ++= Seq("-encoding", "UTF-8") took care of the problem above. It will be in the PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/clulab/corenlp-small/issues/2#issuecomment-774182138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI75TRZQQD2QAZ2B6BZYR3S5QU2LANCNFSM4XD6DBPQ .

kwalcock commented 3 years ago

See #3. The local publish creates three jars: one for class files, another for source files, and a third for javadoc output. The third one was failing. It was trying to expose private inner classes and seemed to have problems with that. Perhaps there are settings to get around it, but Stanford does not publish the javadoc version and it was easier to just disable it. I'm not sure of the effect on a regular publish or release, but one will notice soon enough.

MihaiSurdeanu commented 3 years ago

Thanks!

Since CoreNLP publishes its own Java docs, I think it is safe to disable it.

On Fri, Feb 5, 2021 at 12:02 PM Keith Alcock notifications@github.com wrote:

See #3 https://github.com/clulab/corenlp-small/pull/3. The local publish creates three jars: one for class files, another for source files, and a third for javadoc output. The third one was failing. It was trying to expose private inner classes and seemed to have problems with that. Perhaps there are settings to get around it, but Stanford does not publish the javadoc version and it was easier to just disable it. I'm not sure of the effect on a regular publish or release, but one will notice soon enough.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/clulab/corenlp-small/issues/2#issuecomment-774226960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI75TTMQVG6B5CT7KVZGI3S5Q6DTANCNFSM4XD6DBPQ .