clulab / eidos

Machine reading system for World Modelers
Apache License 2.0
36 stars 24 forks source link

[DART-1003] - Refactoring how variables are set via environment and config file #1002

Closed yanzv closed 3 years ago

kwalcock commented 3 years ago

Thanks for the update. There are plain Apps for the old way of doing things and LoopApps for doing them automatically.

kwalcock commented 3 years ago

Have the changes been verified to work on a "Friday"?

yanzv commented 3 years ago

I am working on building docker container and will be able to test it in DART environment. Let me test it first before merging this PR.

kwalcock commented 3 years ago

FWIW I'm working on the conflicts.

kwalcock commented 3 years ago

GitHub wanted several things done on the command line which resulted in #1013 which was then merged. This PR will probably disappear one way or the other.