search

clulab / eidos

Machine reading system for World Modelers
Apache License 2.0
37 stars 24 forks source link

Account for matches is separate sentences #1005

Closed kwalcock closed 3 years ago

kwalcock commented 3 years ago

is -> in

kwalcock commented 3 years ago

@zupon, your attentiveness caught an interesting phenomenon. This paragraph has two instances of flooding in separate sentences. The NodeSpec seemed to match both. They change order in the list of Mentions, so sometimes the NodeSpec finds the one instead of the other. However, the == between the edge's effect argument and the mention found by the NodeSpec doesn't always hold because they are in different sentences. That's a first. This should fix the problem. It's already in master, but you need it for your tests, maybe without resyncing with master. So, merge if you'd like.

zupon commented 3 years ago

Thanks for looking into this!