search

clulab / eidos

Machine reading system for World Modelers
Apache License 2.0
36 stars 24 forks source link

Merge with master #1047

Closed kwalcock closed 3 years ago

kwalcock commented 3 years ago

This merge with master seemed to take care of the problems with TestGrounding and TestGrounderStability. There was still infinite recursion in TestSRLGrounder, though.

kwalcock commented 3 years ago

On the one the only problem is TestSRLGrounder causing infinite recursion. Remember than any graphs can have loops.

BeckySharp commented 3 years ago

@kwalcock though now after the merge I'm having compile isssues all the places where we are constructing a dependency graph, because now the constructor wants the roots. e.g., when deserializing the sentenceObj from the jsonld. Did you already make a fix for that and I messed it up? or should I work on it?

kwalcock commented 3 years ago

Uh oh. It's supposed to not want the roots now. I'll check.

BeckySharp commented 3 years ago

i may be using the wrong procVersion or constructor

kwalcock commented 3 years ago

I just did a checkout srl_ner and built and ran tests with IntelliJ and it didn't have a problem. Should I look harder? Processors has been updated so that it calculates the roots automatically starting with 8.4.3. Local changes that weren't yet at github could cause problems.

kwalcock commented 3 years ago

FWIW the dependency on processors is in a subproject, eidoscommon, and IntelliJ will not automatically detect a change to the build.sbt file in that directory. IntelliJ needs to be manually instructed to reload the main project to notice the change.