search

clulab / eidos

Machine reading system for World Modelers
Apache License 2.0
36 stars 24 forks source link

GroundExporter and RegroundExporter #1059

Closed BeckySharp closed 3 years ago

BeckySharp commented 3 years ago

Seem to be essentially the same except for some likely unused debug log code in the latter. I say we remove the reground one, if we do, we should also remove it from the wiki.

kwalcock commented 3 years ago

I removed the RegroundExporter. However, I preserved the debug code by moving it to the GroundExporter. It looks like people had been commenting it in then out then in. I added a boolean that we can just flip between true and false so that people can do it ad hoc and don't need to check in the code change as often. I'm updating the Wiki. The PR will be ready soon.

BeckySharp commented 3 years ago

I removed the RegroundExporter. However, I preserved the debug code by moving it to the GroundExporter. It looks like people had been commenting it in then out then in. I added a boolean that we can just flip between true and false so that people can do it ad hoc and don't need to check in the code change as often. I'm updating the Wiki. The PR will be ready soon.

thanks!! :)