Update test grounding - Githubissues

zupon commented 3 years ago

This PR updates TestGrounding.scala to

Test grounding for all four slots of the compositional ontology (theme, theme property, process, process property) instead of just the theme
Make sure each slot grounds to the proper branch of the ontology (theme -> wm/concept/, properties -> wm/property/, process -> wm/process/)

MihaiSurdeanu commented 3 years ago

This is great!!

kwalcock commented 3 years ago

The "not match" part might be a challenge, but a challenge for the next PR. I'll merge as soon as the test finishes.

kwalcock commented 3 years ago

@zupon, the grounding tests are failing. Do some need to be turned off temporarily when the grounder gets the wrong answer?

MihaiSurdeanu commented 3 years ago

Yes, let's do that for now.

On Thu, Aug 19, 2021 at 1:23 PM Keith Alcock @.***> wrote:

@zupon https://github.com/zupon, the grounding tests are failing. Do some need to be turned off temporarily when the grounder gets the wrong answer?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/clulab/eidos/pull/1064#issuecomment-902218633, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI75TSLQYDXEVW6JXF27ELT5VR3RANCNFSM5COWPMIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

clulab / eidos

Update test grounding #1064