search

clulab / eidos

Machine reading system for World Modelers
Apache License 2.0
36 stars 24 forks source link

Compose compositional groundings #1116

Closed kwalcock closed 2 years ago

kwalcock commented 2 years ago

I should go over this again and clean it up, particularly if the code continues to be used. It's the version doing the reading right now and it is otherwise only tagged. Quite a bit of dead code has accumulated and the unit tests should also be revised to stay relevant, but not on this PR.

MihaiSurdeanu commented 2 years ago

Agreed! Thanks Keith!

kwalcock commented 2 years ago

This is going in followed right away by the wmexchanger branch which has all the additional compositional changes.