clulab / eidos

Machine reading system for World Modelers
Apache License 2.0
36 stars 24 forks source link

Cause and effect start on same word #364

Open kwalcock opened 6 years ago

kwalcock commented 6 years ago

In some cases were seeing cause and effect overlap, and in fact starting on the same word. Six of the 52 test files exhibit the problem.

So far this has been noticed to happen with three rules and these counts: 7 - syntax_explicit_Correlation_given 1 - ported_syntax_5_verb-Causal 1 - dueToSyntax2-Causal

Diffs of the zipped files attached will lead to the sentences, rules, etc. in question. One example is

"In Leer, available evidence from the recent FSNMS data conducted during the lean season July/August suggests some households were in Catastrophe (IPC Phase 5) at the peak of the lean season, and given the likelihood that not all households have access to a harvest, it is expected that some households could still be in Catastrophe (IPC Phase 5)."

which results in

List(Correlation, UndirectedRelation, EntityLinker, Event) => given the likelihood that not all households have access to a harvest, it is expected

Rule => syntax_explicit_Correlation_given
Type => EventMention
------------------------------
trigger => given
cause (Concept, Entity) => likelihood
effect (Concept, Entity) => likelihood that not all households have access to a harvest, it is expected

OverlappedCauseAndEffect.zip

BeckySharp commented 6 years ago

@marcovzla fyi (but you don't need to do anything about it!!)

kwalcock commented 5 years ago

Eidos seems to have a problem with this file: <I'm checking on which is the real culprit>.

15:18:44.641 [scala-execution-context-global-100] INFO  org.clulab.wm.eidos.utils.Sourcer$ - Sourcing file ..\..\..\indra-to-lucene\indra-to-lucene-clone\UN_text_content\UN_text_content\001\1952_Document_a-bm656e.txt
[error] (run-main-0) java.lang.RuntimeException: unexpected overlap of trigger and argument
[error] java.lang.RuntimeException: unexpected overlap of trigger and argument
[error]         at scala.sys.package$.error(package.scala:27)
[error]         at org.clulab.wm.eidos.EidosActions.expandIfNotAvoid(EidosActions.scala:550)
[error]         at org.clulab.wm.eidos.EidosActions.$anonfun$expandArguments$7(EidosActions.scala:511)
[error]         at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:234)
[error]         at scala.collection.mutable.ArraySeq.foreach(ArraySeq.scala:74)
[error]         at scala.collection.TraversableLike.map(TraversableLike.scala:234)
[error]         at scala.collection.TraversableLike.map$(TraversableLike.scala:227)
[error]         at scala.collection.AbstractTraversable.map(Traversable.scala:104)
[error]         at org.clulab.wm.eidos.EidosActions.$anonfun$expandArguments$6(EidosActions.scala:511)
[error]         at scala.collection.TraversableLike$WithFilter.$anonfun$map$2(TraversableLike.scala:739)
[error]         at scala.collection.immutable.Map$Map2.foreach(Map.scala:146)
[error]         at scala.collection.TraversableLike$WithFilter.map(TraversableLike.scala:738)
[error]         at org.clulab.wm.eidos.EidosActions.$anonfun$expandArguments$4(EidosActions.scala:510)
[error]         at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:234)
[error]         at scala.collection.Iterator.foreach(Iterator.scala:929)
[error]         at scala.collection.Iterator.foreach$(Iterator.scala:929)
[error]         at scala.collection.AbstractIterator.foreach(Iterator.scala:1417)
[error]         at scala.collection.IterableLike.foreach(IterableLike.scala:71)
[error]         at scala.collection.IterableLike.foreach$(IterableLike.scala:70)
[error]         at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
[error]         at scala.collection.TraversableLike.map(TraversableLike.scala:234)
[error]         at scala.collection.TraversableLike.map$(TraversableLike.scala:227)
[error]         at scala.collection.AbstractTraversable.map(Traversable.scala:104)
[error]         at org.clulab.wm.eidos.EidosActions.expandArguments(EidosActions.scala:500)
[error]         at org.clulab.wm.eidos.EidosActions.globalAction(EidosActions.scala:34)
[error]         at org.clulab.wm.eidos.EidosSystem$LoadableAttributes$.$anonfun$apply$2(EidosSystem.scala:117)
[error]         at org.clulab.odin.ExtractorEngine.extract$1(ExtractorEngine.scala:49)
[error]         at org.clulab.odin.ExtractorEngine.loop$1(ExtractorEngine.scala:34)
[error]         at org.clulab.odin.ExtractorEngine.extractFrom(ExtractorEngine.scala:56)
[error]         at org.clulab.wm.eidos.EidosSystem.extractEventsFrom(EidosSystem.scala:178)
[error]         at org.clulab.wm.eidos.EidosSystem.extractFrom(EidosSystem.scala:193)
[error]         at org.clulab.wm.eidos.EidosSystem.extractFromText(EidosSystem.scala:153)
[error]         at org.clulab.wm.eidos.apps.ExtractFromDirectory$.$anonfun$new$1(ExtractFromDirectory.scala:41)
[error]         at org.clulab.wm.eidos.apps.ExtractFromDirectory$.$anonfun$new$1$adapted(ExtractFromDirectory.scala:34)
[error]         at scala.collection.parallel.mutable.ParArray$ParArrayIterator.foreach(ParArray.scala:142)
[error]         at scala.collection.parallel.ParIterableLike$Foreach.leaf(ParIterableLike.scala:970)
[error]         at scala.collection.parallel.Task.$anonfun$tryLeaf$1(Tasks.scala:49)
[error]         at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
[error]         at scala.util.control.Breaks$$anon$1.catchBreak(Breaks.scala:63)
[error]         at scala.collection.parallel.Task.tryLeaf(Tasks.scala:52)
[error]         at scala.collection.parallel.Task.tryLeaf$(Tasks.scala:46)
[error]         at scala.collection.parallel.ParIterableLike$Foreach.tryLeaf(ParIterableLike.scala:967)
[error]         at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal(Tasks.scala:166)
[error]         at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal$(Tasks.scala:153)
[error]         at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.internal(Tasks.scala:440)
[error]         at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute(Tasks.scala:146)
[error]         at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute$(Tasks.scala:145)
[error]         at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.compute(Tasks.scala:440)
[error]         at java.util.concurrent.RecursiveAction.exec(Unknown Source)
[error]         at java.util.concurrent.ForkJoinTask.doExec(Unknown Source)
[error]         at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(Unknown Source)
[error]         at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
[error]         at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source)
[error] java.lang.RuntimeException: Nonzero exit code: 1
[error]         at sbt.Run$.executeTrapExit(Run.scala:124)
[error]         at sbt.Run.run(Run.scala:77)
[error]         at sbt.Defaults$.$anonfun$bgRunMainTask$6(Defaults.scala:1163)
[error]         at sbt.Defaults$.$anonfun$bgRunMainTask$6$adapted(Defaults.scala:1158)
[error]         at sbt.internal.BackgroundThreadPool.$anonfun$run$1(DefaultBackgroundJobService.scala:366)
[error]         at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
[error]         at scala.util.Try$.apply(Try.scala:209)
[error]         at sbt.internal.BackgroundThreadPool$BackgroundRunnable.run(DefaultBackgroundJobService.scala:289)
[error]         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
[error]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
[error]         at java.lang.Thread.run(Unknown Source)
[error] (Compile / runMain) Nonzero exit code: 1
MihaiSurdeanu commented 5 years ago

This clearly should not be allowed...

Where should we handle this, @marcovzla and @bsharpataz? Inside Odin (that is, report a warning, and drop the mention), or inside a global action in eidos?

BeckySharp commented 5 years ago

I think its an eidos issue. I’ll try to work on it tomorrow between meetings...?

On Mon, Aug 13, 2018 at 6:49 PM Mihai Surdeanu notifications@github.com wrote:

This clearly should not be allowed...

Where should we handle this, @marcovzla https://github.com/marcovzla and @bsharpataz https://github.com/bsharpataz? Inside Odin (that is, report a warning, and drop the mention), or inside a global action in eidos?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/clulab/eidos/issues/364#issuecomment-412726009, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIniRojXMqn43y6NIB1nNzHQ-J-G0mAks5uQiy4gaJpZM4VEmK7 .

BeckySharp commented 5 years ago

where does that text file live, btw?

On Mon, Aug 13, 2018 at 8:15 PM Rebecca bsharp@email.arizona.edu wrote:

I think its an eidos issue. I’ll try to work on it tomorrow between meetings...?

On Mon, Aug 13, 2018 at 6:49 PM Mihai Surdeanu notifications@github.com wrote:

This clearly should not be allowed...

Where should we handle this, @marcovzla https://github.com/marcovzla and @bsharpataz https://github.com/bsharpataz? Inside Odin (that is, report a warning, and drop the mention), or inside a global action in eidos?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/clulab/eidos/issues/364#issuecomment-412726009, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIniRojXMqn43y6NIB1nNzHQ-J-G0mAks5uQiy4gaJpZM4VEmK7 .

kwalcock commented 5 years ago

It looks like 1949_Book_a-an468e.txt and 1950_Book_a-ap638e.txt are both problems. They are unfortunately >300KB and take some time before they error out. I'll be looking for easier ones to break. They live in WorldModelers/resources/corpora/FAO/UN_text_content.zip on Google Drive. (At least I hope that's the correct file. I'm none to clear on the origin of these things.)

kwalcock commented 5 years ago

Here's a smaller file with the same error: 2016_Mixed Material_a-i6232e.txt

kwalcock commented 5 years ago

2013_Book_a-aq404e.txt 2016_Mixed Material_a-i5563e.txt 2013_Mixed Material_a-av122e.txt 2009_Meeting_a-ak536e.txt 2008_Document_a-ai556e.txt 2015_Book_a-i4353e.txt 2007_Meeting_a-j9880e.txt 2011_Document_a-ax830e.txt 2016_Mixed Material_a-i5600e.txt 2016_Serials_a-i5874e.txt 2006_Meeting_a-bo733e.txt 1957_Document_a-bm602e.txt 2005_Book_a-a0159e.txt 2009_Meeting_a-k4275e.txt 2002_Meeting_a-ab504e.txt 2016_Mixed Material_a-i5620e.txt 2008_Reports_a-bd080e.txt

That should be enough. It's probably the same problem each time.

kwalcock commented 5 years ago

Uh oh. Heads up, @bsharpataz, I'm seeing things like these again. I do like the new format of the message.

09:31:32.975 [scala-execution-context-global-19] DEBUG org.clulab.wm.eidos.EidosActions - Unexpected overlap of trigger and argument: sent: [Key recommendations include : Understand the risks better More research is needed to understand and quantify the risks set out in this report .] RULE: is_critical_to-Causal trigger: needed orig: [needed to understand]

09:31:32.976 [scala-execution-context-global-19] DEBUG org.clulab.wm.eidos.EidosActions - Unexpected overlap of trigger and argument: sent: [Key recommendations include : Understand the risks better More research is needed to understand and quantify the risks set out in this report .] RULE: is_critical_to-Causal trigger: needed orig: [needed to understand]

09:31:32.993 [scala-execution-context-global-19] DEBUG org.clulab.wm.eidos.EidosActions - Unexpected overlap of trigger and argument: sent: [6.1 Better understand the risks More research is needed to understand and quantify the risks set out in this paper .] RULE: is_critical_to-Causal trigger: needed orig: [needed to understand]

09:31:36.578 [scala-execution-context-global-21] DEBUG org.clulab.wm.eidos.EidosActions - Unexpected overlap of trigger and argument: sent: [46 % EEQ Given the high level of food insecurity and Upper Nile shocks , it is not surprising that there has been an WBeG impact on coping mechanisms .] RULE: syntax_explicit_Correlation_given trigger: Given orig: [46% EEQ

Given]

09:31:36.578 [scala-execution-context-global-21] DEBUG org.clulab.wm.eidos.EidosActions - Unexpected overlap of trigger and argument: sent: [46 % EEQ Given the high level of food insecurity and Upper Nile shocks , it is not surprising that there has been an WBeG impact on coping mechanisms .] RULE: syntax_explicit_Correlation_given trigger: Given orig: [46% EEQ

Given]

09:31:36.579 [scala-execution-context-global-21] DEBUG org.clulab.wm.eidos.EidosActions - Unexpected overlap of trigger and argument: sent: [46 % EEQ Given the high level of food insecurity and Upper Nile shocks , it is not surprising that there has been an WBeG impact on coping mechanisms .] RULE: syntax_explicit_Correlation_given trigger: Given orig: [46% EEQ

Given]

BeckySharp commented 5 years ago

thanks.... :( I'll bump it up my priority list.... but that list is tooooo long :(

On Thu, Nov 1, 2018 at 9:51 AM Keith Alcock notifications@github.com wrote:

Reopened #364 https://github.com/clulab/eidos/issues/364.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clulab/eidos/issues/364#event-1940975050, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIniQXI1jCbDOc6gmKxOeXxbdK_29k0ks5uqyaOgaJpZM4VEmK7 .