search

clulab / processors

Natural Language Processors
https://clulab.github.io/processors/
Apache License 2.0
418 stars 100 forks source link

Normalize "grand" #694

Open maxaalexeeva opened 1 year ago

maxaalexeeva commented 1 year ago

Need to normalize "grand" to (probably) 1000 or thousand, e.g., "we're about 180 acres under pivot and that's it of our four grand." (note: grand is not necessarily about $)

maxaalexeeva commented 1 year ago

Also, maybe "dozen" if it's not yet there? There's also "baker's dozen", which is 13, but I don't know how frequent that is. And "fortnight" = 14 days.

maxaalexeeva commented 1 year ago

half/quarter if they are not there.

MihaiSurdeanu commented 1 year ago

Thanks Masha! I'll take it from here.

MihaiSurdeanu commented 1 year ago

"grand" and "dozen" have been added and just merged in master.

maxaalexeeva commented 1 year ago

thanks! will you want to add the other ones or shall I close this?

MihaiSurdeanu commented 1 year ago

Leave it open. But I think it will be a couple of weeks until I get to it. Those are trickier. Meanwhile, @kwalcock: you can release if you think it helps.

kwalcock commented 1 year ago

I'd like to make a v8.5.3rc4 with the additional two PRs that are outstanding and deploy to Artifactory for use with the SEC and/or habitus projects and if that works, clean up the CHANGES file for deployment to maven.