search

clulab / processors

Natural Language Processors
https://clulab.github.io/processors/
417 stars 101 forks source link

Put clulab in charge of its own holidays #772

Closed kwalcock closed 6 months ago

MihaiSurdeanu commented 6 months ago

Nice, thank you @kwalcock !

kwalcock commented 6 months ago

I think this is good enough for now. It gives us access to newer holidays even though it uses an older JollyDay, and we can (and have) added our own holidays. The HolidayNormalizer should be multiple times faster because it doesn't go through holidays of every separate state and it matches based on keys rather than descriptions, which are an extra call away.

kwalcock commented 6 months ago

P.S. This should prevent eidos from crashing while processing habitus files and SEC software from crashing on interviews.